This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(ui): bump @nextcloud/vue to ^8.39.0 (nav corner sliver on NC<34)#1917
Merged
Conversation
On Nextcloud servers older than 34, @nextcloud/vue <8.39.0 unconditionally renders the NC34 app layout, which rounds the .app-content left corners (border-radius: 16px 0 0 16px). Against the still-square translucent .app-navigation this leaves a white sliver poking out at the nav/content seam near the collapse toggle. 8.39.0 added a server-version guard (isLegacy34 = NC major < 34) that applies the content--legacy / app-navigation--legacy modifiers to keep the old flush, square layout on NC<34, eliminating the sliver. Bump both the direct dependency and the overrides pin so the new version is actually resolved.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ✅ 532/532 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 21:53 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A small white curved sliver appears at the top of the app navigation, next to the collapse toggle, on Nextcloud < 34 (this dev server is NC 32).
Root cause
NC 34 introduced a new app layout where
.app-contentis a rounded card (border-radius: 16px 0 0 16px).@nextcloud/vue8.39.0 added a server-version guard (isLegacy34 = NC major < 34) that appliescontent--legacy/app-navigation--legacyto keep the old flush, square layout on NC < 34. Versions ≤ 8.38.0 lack this guard and unconditionally render the rounded layout, so the white.app-contentcorner pokes past the still-square translucent.app-navigation→ the sliver.Verified live: openconnector (8.39.0) renders
app-navigation--legacy+border-radius: 0and is clean; openregister/opencatalogi/pipelinq/doriath (≤8.38) show the sliver.Fix
Bump
@nextcloud/vueto^8.39.0in both the direct dependency and theoverridespin (the override was the binding constraint). No code changes — the guard lives in the library.js/is gitignored, so CI rebuilds the bundle on release.Part of a fleet-wide sweep across all apps built against @nextcloud/vue < 8.39.0.