This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(support-dialog): custom mount + preferences endpoint + nc-vue beta.102#1918
Merged
Merged
Conversation
…ta.102
OpenRegister keeps its own root (the CnAppRoot migration is deferred),
so the first-open support note is wired manually in App.vue:
useSupportDialog('openregister', {persistence:'server'}) +
<CnSupportDialog>, persisting the per-user "seen" flag via the new
GET/PUT /api/preferences/{key} endpoint (IConfig user values,
localStorage fallback). Bumps @conduction/nextcloud-vue beta.32 -> beta.102
to pull in CnSupportDialog/useSupportDialog. Build verified green.
When the CnAppRoot shell migration lands, drop the manual block in
App.vue and rely on CnAppRoot's built-in auto-mount instead.
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
rubenvdlinde
added
ready-for-code-review
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ✅ 539/539 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 22:23 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the fleet support dialog to OpenRegister without waiting on the (deferred) CnAppRoot shell migration — wired manually in
App.vue.src/App.vue:useSupportDialog('openregister', { persistence: 'server' })+<CnSupportDialog>(app name/slug/App-Store/feature-request props). A<!-- … -->note marks it to be removed in favour ofCnAppRoot's built-in auto-mount once the shell migration lands.GET/PUT /api/preferences/{key}(IConfig user values,pref_*namespace, key-sanitised) — per-user "seen" flag, cross-device, localStorage fallback. Canonical controller (mirrors pipelinq#553 / nat#68).@conduction/nextcloud-vuebeta.32→beta.102— pulls inCnSupportDialog/useSupportDialog.Gates
npm run build— green (webpack 5.107.2 compiled, 28 pre-existing warnings, no errors). The 70-version lib jump compiles OR's source cleanly.php -lclean;phpcs --standard=phpcs.xml— 0 errors (3 advisory@specwarnings).Notes