Repository navigation
fix(review): #4580 union-path facet skip, round 3 - #4710
Merged
Merged
Conversation
… across every schema Threads: #4580 (comment) #4580 (comment) #4580 (comment) - getTermsFacetUnion() skipped the object-name lookup when the FIRST table's schema declared a referenceType for the column, so a union whose later schema holds real object references lost those names. The new anyHoldsObjectReferences() keeps the lookup unless every schema of the union declares a referenceType. - testUnionIntegrationReferencesAreNotLookedUpAsObjects calls the union path with a referenceType property and expects no lookup; removing the skip turns it red. testUnionKeepsTheLookupWhenAnySchemaHoldsObjectReferences pins the mixed union; the first-schema-only check turns it red. - The @SPEC exclude text on holdsObjectReferences() now says a UUID-shaped integration id is labelled in full instead of its shortened form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 26676/26676 · 25 skipped | ||||
| Newman | ✅ 714/714 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-20 08:33 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for rjzondervan's round-2 review of #4580 (#4580 (review)). Merge into
development, then re-request the review.Findings → commits
referenceTypeskip has no test6c025c4949testUnionIntegrationReferencesAreNotLookedUpAsObjectscallsgetTermsFacetUnion()with areferenceTypeproperty and expects no name lookup; removing the skip turns it red.6c025c4949anyHoldsObjectReferences(): the lookup is skipped only when every schema of the union declares areferenceTypefor the column.testUnionKeepsTheLookupWhenAnySchemaHoldsObjectReferencespins the mixed union and is red on the first-schema-only check.referenceTypeproperties change6c025c4949@spec excludetext onholdsObjectReferences()says a UUID-shaped integration id is now labelled in full instead of its shortened form.Not in this PR: the shared facet label cache (thread), pre-existing on
betaand tracked in #4705.Checks run on this branch
phpunit -c phpunit-unit-local.xml --filter Facet tests/Unit→ OK, 139 tests (2 skipped)composer phpcs→ exit 0; phpmd with the baseline → no findings; phpstan onMagicFacetHandler.php→ no errorsrun-hydra-gates.sh --scope-to-diff --base origin/development→ exit 0, 34 of 34 applicable gates ran🤖 Generated with Claude Code