Repository navigation
docs(openspec): re-rated rows and specs for unspecified built capabilities - #515
Merged
Merged
Conversation
Contributor
Quality Report — ConductionNL/versioniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 32/32 | |||
| npm | ✅ | ✅ 302/302 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-07 21:16 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec round part 2 of 7 October (decisions 78 and 81). No code changes: only
openspec/moves.1. Re-rated rows
src-connection-statusintegriq/connection-registryadopt-connection-registrysrc/components/IntegrationsPanel.vue:152,:156); reports come fromConnectionReportService, called by the App Store source, the advisory feed and the token save and removal.adm-connections-panelintegriq/connection-registryadopt-connection-registrysrc/App.vue:2735mounts the panel when integriq is enabled (lib/Settings/Admin.php:53).inv-compat-serverbuilt.spec: openspec/specs/version-managementForgeRangeStoredoes not exist, so it stays specified ininventory-upgrade-readiness.adm-openapiopenapi.jsonlacksGET /api/updates, added in #493, so the description is one route behind and the openapi check stays red untilcomposer run openapiis committed.The two connection rows now link the local change
adopt-connection-registry, which holds the code; integriq'sconnection-registryis archived on integriq (2026-09-29-connection-registry). Both stay partial: the tab is absent without integriq, and a self-hosted Forgejo or Gitea forge has no row. The local change still has task 5.1 open (live e2e run with integriq), so it is not archived.2. Specs for our own
spec: nonerowsadmin-api(new)adm-api,adm-openapiversion-managementinv-search-filter,rel-filter-versions,adm-a11ymigration-safetysaf-signature,saf-maintenance-modesecurity-advisory-correlationTBDPurpose is replaced.adv-branch-aware,adv-refresh-interval,adv-digestaudit-trail(no edit, already carries it)GET /api/audit), "Instance settings on a page" (advisory.feed_basemirror)aud-export,adv-offline-dbLeft at
spec: none, because they are not our code:adm-self-hosted(the platform runs it on premises) andadm-free(a licence fact, no code path).Verified
python3 -m json.tool: valid.parity_verify.py --strict: exit 0, only the unknown-cells census.openspec validate --specs --strict: 14 of 15 pass. The one failure is inherited and untouched:source-license-headersstill carries theTBDPurpose.--scope-to-diff: exit 0. Gate 19 (advisory) lists 36 scenarios without a test-file reference; 32 are older scenarios in the spec files this PR touches. Four are new and have a real test that does not yet carry the scenario reference (tests/e2e/pending-updates.spec.tsfor the two admin-api scenarios,tests/e2e/shell.spec.tsfor the arrow keys,tests/e2e/advisories.spec.tsfor the interval). Adding those references is atests/edit, outside this round. Gate 46 had no input.Needs Ruben
openapi.json(composer run openapi) soadm-openapican go back to yes. It is the smallfix/openapi-updates-routePR already in versioniq's queue.InstallerServiceTestonly runs with maintenance already on. The new migration-safety scenario says so.