Require every track to name a track type and rework menu run flow - #123
Merged
Conversation
- remove the built-in default type and the reserved "default" name; an edge without track_type now fails to compile (CompileError::MissingTrackType) and is flagged by the rule check - content built-ins, the OSM importer (--track-type) and the route editor's lay tool write example:hauptbahn as an authoring default - track_type_at returns an Option; consumers fall back on welded-mainline roughness/reverb
vanlueckn
force-pushed
the
t3code/investigate-mixed-track-modules
branch
from
September 2, 2026 15:50
dd8ab2e to
a775299
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"default"name. Modules that leave it out fail to compile withCompileError::MissingTrackType(<edge>), and the route editor's rule check reports the same before a run.depends:.track_type_at(audio roughness/reverb, precipitation reverb) now handle theOptionexplicitly instead of assuming a default."default"name.Testing
cargo test --workspace— expecting 1136 tests green, including i18n key parity checks.track_typefails to compile withMissingTrackType.