Add source parameter to ASA submit tracking - #485
Open
dmitrycnstrc wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, type definitions and documentation are updated, and tests verify the new request parameter is sent correctly.
Pull request overview
Adds support for an optional source field on the ASA “submit” tracking event so clients can indicate how an intent submission occurred (e.g., from a suggested question), and ensures the parameter is sent through to the request payload and covered by tests.
Changes:
- Extend
trackAgentSubmitparameters to accept optionalsourceand include it in the POST body when provided. - Update JSDoc and TypeScript declarations to reflect the new optional parameter.
- Update unit tests to validate
sourceis included in the request.
File summaries
| File | Description |
|---|---|
| src/types/tracker.d.ts | Adds source?: string to the trackAgentSubmit type signature. |
| src/modules/tracker.js | Documents source and conditionally appends it to bodyParams for the submit tracking request. |
| spec/src/modules/tracker.js | Extends the trackAgentSubmit test to include source and asserts it’s present in the request body. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.