Load the data-driven beacon and move indexKey to the head - #23
Open
rheav wants to merge 1 commit into
Open
Conversation
Replaces the legacy integration-sandbox beacon with the DDB bundle built for this site, and moves window.cnstrc.indexKey out of the React bundle into the document head, so the beacon no longer depends on application code having executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
public/index.htmlloadedintegration-sandbox_iRpDiA.js, a legacy beacon with a different hardcoded API key that tracks through CSS selectors instead ofdata-cnstrc-*attributes. The tag had nodeferand sat after</body>.window.cnstrc.indexKeywas set insrc/index.jsx, so beacon config lived in the React bundle. Nothing in the app read it: the JS client gets its key from theConstructorIOClientconstructor insrc/app/cioClient.js.What changed
Removed the legacy tag. Added to the
<head>ofpublic/index.html:Removed the three
window.cnstrclines fromsrc/index.jsx. The inline script runs during parsing, so the key is set before the deferred beacon executes.Placement follows Direct site placement.