add a common object for browse and search request - #189
Open
as-smets wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Java client’s browse/search request models by extracting shared request parameters into a common base class, reducing duplication between BrowseRequest and SearchRequest.
Changes:
- Introduces
BrowseSearchBaseRequestto hold common browse/search parameters (pagination, facets, sorting, etc.). - Updates
SearchRequestto extend the new base request and removes duplicated fields/accessors. - Updates
BrowseRequestto extend the new base request and removes duplicated fields/accessors.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| constructorio-client/src/main/java/io/constructor/client/SearchRequest.java | Switches search request model to inherit shared parameters from the new base request. |
| constructorio-client/src/main/java/io/constructor/client/BrowseSearchBaseRequest.java | Adds the new shared base request containing common browse/search fields and accessors. |
| constructorio-client/src/main/java/io/constructor/client/BrowseRequest.java | Switches browse request model to inherit shared parameters from the new base request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
as-smets
force-pushed
the
chore/actract-base-search-browse-request
branch
from
September 1, 2026 12:24
af7ed1c to
13896bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #188
To be able to factorize code between search and browse common request parameters
I didn't want the object to be called only
BaseRequestso I choseBrowseSearchBaseRequestbut not totally convinced