Skip to content

[NO-CDX] Fix breaking React compatibility tests #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mudaafi wants to merge 2 commits into from
Closed

[NO-CDX] Fix breaking React compatibility tests #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2ce583
fix breaking compat tests
Mudaafi Aug 27, 2026
1e1232b
ignore package-lock to allow different react versions
Mudaafi Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/react-compat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with:
node-version: "22.18.0"
- name: Install library deps
run: npm ci
run: npm i --no-audit --no-fund --package-lock=false

@constructor-claude-bedrock constructor-claude-bedrock Bot Aug 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important Issue: Replacing npm ci with npm i --package-lock=false undermines CI reproducibility. npm ci exists precisely to enforce a clean, deterministic install from the lockfile — which is what CI should be doing. Using npm i --package-lock=false instead means dependencies can silently resolve to different (potentially breaking or vulnerable) versions on each run.

The root cause here is that npm ci was failing, likely because the package-lock.json is out of sync with package.json, or the lockfile does not exist. The correct fix is to identify and resolve that mismatch rather than bypassing the lockfile altogether.

If the intent is to allow installing the latest compatible versions of deps for testing against different React versions, a more explicit and intentional approach would be to document this decision and use a separate package.json install step that updates only the peer dependency (React) before running npm ci on the rest — or to rely on the already-present npm ci --no-audit --no-fund in the fixture install step (line 39) which already correctly uses npm ci.

Suggested fix: Investigate why npm ci was failing (likely a stale or missing package-lock.json) and fix the lockfile rather than bypassing it. If dynamic resolution is truly required for this step, add a comment explaining the rationale.

- name: Build library
run: npm run compile
- name: Pack library
Expand Down
Loading