Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
**Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
**Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
**Prevention:** Always implement explicit runtime type validation for optional boolean parameters.
## 2024-05-18 - [CRITICAL] Prevent Integer Overflow Coercion in readline Input Validation
**Vulnerability:** Interactive `readline()` prompts for binary choices (e.g., '1' or '2') in `autoFIPC` incorrectly validated input using the unbounded regular expression `^[0-9]+$`. This allows arbitrarily large numeric strings (e.g., "999999999999999999999") to pass the regex check, which subsequently evaluates to `NA` when coerced via `as.integer()`, potentially causing unhandled exceptions or process crashes.
Comment on lines +5 to +6
**Learning:** The previous validation implementation used `^[0-9]+$` allowing unbounded numeric digits, assuming `as.integer()` would handle it securely. However, R's `as.integer()` returns `NA` with a warning for out-of-range large integers, which leaks into subsequent logic that expects an integer.
**Prevention:** Strictly limit allowed character patterns matching exact expected literal values (e.g., `^[12]$`) instead of generic type structures (e.g., all digits) when validating string inputs bound for type coercion or conditionals.
6 changes: 3 additions & 3 deletions R/aFIPC.R
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ autoFIPC <-
}
for (attempt in seq_len(3)) {
n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
Comment on lines 142 to 146
}
Expand Down Expand Up @@ -171,7 +171,7 @@ autoFIPC <-
readline(
prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
)
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down Expand Up @@ -390,7 +390,7 @@ autoFIPC <-
readline(
prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
)
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down
Loading