π¨ Palette: [UX improvement] μ€μ½μ΄ λ·°μ΄ μμ΄μ½ λ²νΌ ν΄ν μΆκ°#668
π¨ Palette: [UX improvement] μ€μ½μ΄ λ·°μ΄ μμ΄μ½ λ²νΌ ν΄ν μΆκ°#668seonghobae wants to merge 2 commits into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Adds native hover tooltips to icon-only controls in the desktop score viewer by mirroring existing i18n aria-label strings into title attributes, improving discoverability for mouse users.
Changes:
- Add
title={t(...)}to Zoom In/Out icon buttons inScoreViewer. - Add
title={t(...)}to Previous/Next Page icon buttons inScoreViewer. - Append a new UI/UX learning note to
.Jules/palette.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/desktop/src/features/score/ScoreViewer.tsx | Adds localized title attributes to icon-only buttons to show native hover tooltips. |
| .Jules/palette.md | Records an additional Palette learning/action item related to button disabled-state styling. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| **Learning:** Inline clear buttons often unmount immediately after clearing state, which can drop keyboard focus to the document body. | ||
| **Action:** Move focus back to the owning input before clearing state, and cover the behavior with a DOM focus test. | ||
|
|
||
| ## 2024-07-21 - Visual Regression on Custom Buttons when migrating to aria-disabled |
| aria-label={t("scoreViewerPrevPage")} | ||
| title={t("scoreViewerPrevPage")} | ||
| disabled={pageNumber <= 1} | ||
| onClick={goToPreviousPage} | ||
| > |
| aria-label={t("scoreViewerNextPage")} | ||
| title={t("scoreViewerNextPage")} | ||
| disabled={pageNumber >= pageCount} | ||
| onClick={goToNextPage} | ||
| > |
π‘ What: μ€μ½μ΄ λ·°μ΄μ μμ΄μ½ μ μ© λ²νΌ(νλ, μΆμ, μ΄μ νμ΄μ§, λ€μ νμ΄μ§)μ
titleμμ±μ μΆκ°νμ¬ λ§μ°μ€ νΈλ² μ ν΄νμ μ 곡ν©λλ€.π― Why: μμ΄μ½λ§ μλ λ²νΌμ μκ°μ μΌλ‘ μλ―Έλ₯Ό νμ νκΈ° μ΄λ €μΈ μ μμΌλ―λ‘ ν΄νμ μ 곡νμ¬ μκ° μ₯μ κ° μλ λ§μ°μ€ μ¬μ©μμκ²λ μ κ·Όμ±κ³Ό μ¬μ©μ±μ λμ λλ€.
πΈ Before/After: νμ΄μ§ μ΄λ λ° λ보기 λ²νΌμ λ§μ°μ€λ₯Ό μ¬λ¦¬λ©΄ "Previous page", "Next page", "Zoom In", "Zoom Out" λ±μ ν΄νμ΄ λνλ©λλ€.
βΏ Accessibility: μμ΄μ½ μ μ© λ²νΌμ ν΄νμ μ 곡νμ¬ μκ°μ 컨ν μ€νΈλ₯Ό μΆκ°νμ΅λλ€.
PR created automatically by Jules for task 14483380898445083149 started by @seonghobae