Skip to content

🎨 Palette: 숫자 μž…λ ₯ ν•„λ“œ 빈 κ°’ 인라인 μœ νš¨μ„± 검사 κ°œμ„ #264

Open
seonghobae wants to merge 1 commit into
mainfrom
palette-fix-empty-validation-16269754238760185714
Open

🎨 Palette: 숫자 μž…λ ₯ ν•„λ“œ 빈 κ°’ 인라인 μœ νš¨μ„± 검사 κ°œμ„ #264
seonghobae wants to merge 1 commit into
mainfrom
palette-fix-empty-validation-16269754238760185714

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: target_bytes와 batch_target_bytes μž…λ ₯ ν•„λ“œμ—μ„œ 값을 지웠을 λ•Œ μ»€μŠ€ν…€ μ—λŸ¬(Must be greater than 0.)κ°€ μ¦‰μ‹œ λ‚˜νƒ€λ‚˜μ§€ μ•Šλ„λ‘ this.value === ''일 λ•Œμ˜ 처리λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: μ‚¬μš©μžκ°€ μž…λ ₯ ν•„λ“œλ₯Ό μ§€μš°κ³  λ‹€μ‹œ μž…λ ₯ν•˜λ €κ³  ν•  λ•Œ 빈 λ¬Έμžμ—΄μ΄ NaN으둜 νŒŒμ‹±λ˜λ©΄μ„œ μ˜λ„μΉ˜ μ•Šκ²Œ μ—λŸ¬ λ©”μ‹œμ§€κ°€ ν‘œμ‹œλ˜λŠ” 문제λ₯Ό ν•΄κ²°ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€. 빈 값일 경우 λΈŒλΌμš°μ €μ˜ κΈ°λ³Έ HTML5 required μœ νš¨μ„± 검사에 λ§‘κΈ°λŠ” 것이 μžμ—°μŠ€λŸ½μŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: 빈 λ¬Έμžμ—΄ μž…λ ₯ μ‹œ μ—λŸ¬ λ©”μ‹œμ§€(Must be greater than 0.)κ°€ μ¦‰μ‹œ ν‘œμ‹œλ˜λ˜ κ²ƒμ—μ„œ, λ©”μ‹œμ§€μ™€ aria-invalid 속성이 μ¦‰μ‹œ μ œκ±°λ˜λ„λ‘ λ³€κ²½.
β™Ώ Accessibility: aria-invalid 속성과 프리셋 λ²„νŠΌμ˜ aria-pressed μƒνƒœλ₯Ό λͺ…μ‹œμ μœΌλ‘œ μ œκ±°ν•¨μœΌλ‘œμ¨ 슀크린 리더 μ‚¬μš©μžμ—κ²Œ λΆˆν•„μš”ν•˜κ±°λ‚˜ 잘λͺ»λœ μ—λŸ¬ μƒνƒœκ°€ μ „λ‹¬λ˜μ§€ μ•Šκ²Œ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 16269754238760185714 started by @seonghobae

target_bytes와 batch_target_bytes μž…λ ₯ ν•„λ“œμ—μ„œ 값을 지웠을 λ•Œ μ»€μŠ€ν…€ μ—λŸ¬κ°€ μ¦‰μ‹œ λ‚˜νƒ€λ‚˜μ§€ μ•Šλ„λ‘ `this.value === ''`일 λ•Œμ˜ 처리λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant