π¨ Palette: μ«μ μ λ ₯ νλ λΉμ μνμμμ μΈλΌμΈ μ ν¨μ± κ²μ¬ UX κ°μ #271
Hidden character warning
π¨ Palette: μ«μ μ
λ ₯ νλ λΉμ μνμμμ μΈλΌμΈ μ ν¨μ± κ²μ¬ UX κ°μ #271seonghobae wants to merge 1 commit into
Conversation
`target_bytes` λ° `batch_target_bytes` μ λ ₯ νλμμ λΉ λ¬Έμμ΄ μν(`''`)λ₯Ό λͺ μμ μΌλ‘ μ²λ¦¬νμ¬ μ¬μ©μ μ§μ μ€λ₯ λ©μμ§λ₯Ό μ΄κΈ°ννκ³ aria-invalid μμ±μ μ κ±°νλλ‘ κ°μ νμ΅λλ€. μ΄λ₯Ό ν΅ν΄ μ¬μ©μκ° νλλ₯Ό μ§μΈ λ HTML5 κΈ°λ³Έ νμ κ²μ¦λ³΄λ€ 컀μ€ν μ€λ₯κ° λ¨Όμ λνλλ λ¬Έμ λ₯Ό ν΄κ²°νμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What:
target_bytesλ°batch_target_bytesμ λ ₯ νλμμ λΉ λ¬Έμμ΄ μν('')λ₯Ό λͺ μμ μΌλ‘ μ²λ¦¬νμ¬ μ¬μ©μ μ§μ μ€λ₯ λ©μμ§λ₯Ό μ΄κΈ°ννκ³aria-invalidμμ±μ μ κ±°νμ΅λλ€.π― Why: μ¬μ©μκ° μ λ ₯ νλλ₯Ό μμ ν μ§μΈ λ
parseIntκ°NaNμ λ°ννμ¬ HTML5 κΈ°λ³Έ νμ(required) μ μ½ μ‘°κ±΄μ΄ μλνκΈ° μ μ 'Must be greater than 0.'μ΄λΌλ 컀μ€ν κ²μ¦ μ€λ₯κ° μ±κΈνκ² νΈλ¦¬κ±°λλ UX λ¬Έμ λ₯Ό ν΄κ²°νκΈ° μν¨μ λλ€.πΈ Before/After: μκ°μ λ³ν μμ (λ΄λΆ μν μ²λ¦¬ κ°μ μΌλ‘ μΈν΄ λ μμ°μ€λ¬μ΄ μ ν¨μ± κ²μ¬ νλ¦ μ 곡)
βΏ Accessibility: μλͺ»λ νμ΄λ°μ λΆνμν μ€λ₯ μνκ° μ€μ λκ³
aria-invalidμμ±μ΄ μ μ§λμ΄ μ€ν¬λ¦° 리λ λ±μ νΌλμ μ£Όλ κ²μ λ°©μ§ν©λλ€.PR created automatically by Jules for task 13325911538352561627 started by @seonghobae