π¨ Palette: μ«μ μ λ ₯ νλμ λΉ λ¬Έμμ΄μ λν μ ν¨μ± κ²μ¬ μ²λ¦¬ κ°μ #274
Conversation
- `target_bytes` λ° `batch_target_bytes` μ λ ₯ νλμμ μ¬μ©μκ° κ°μ μ§μ λΉ λ¬Έμμ΄μ΄ λμμ λ 컀μ€ν μ ν¨μ± κ²μ¬ μλ¬μ `aria-invalid` μμ±μ λͺ μμ μΌλ‘ ν΄μ νλλ‘ κ°μ - `.jules/palette.md` νμΌμ λΉ λ¬Έμμ΄ μ²λ¦¬ μν κ΄λ¦¬μ κ΄ν νμ΅ λ΄μ© μΆκ°
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the client-side inline validation behavior for the target_bytes and batch_target_bytes numeric inputs in saas_web.py so that when a user clears the field to an empty string, any previously-set custom validation error and aria-invalid state are explicitly resetβallowing native HTML5 required validation to behave naturally and avoiding misleading βMust be greater than 0.β feedback.
Changes:
- Add an explicit early-return branch for
this.value === ''in both numeric inputinputevent handlers to clearsetCustomValidity, removearia-invalid, clear the preview text, and reset preset buttonaria-pressed. - Document the βempty string handlingβ lesson and action item in
.jules/palette.mdfor future UI validation work.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
saas_web.py |
Resets custom validity + ARIA invalid state on empty numeric input to prevent incorrect error UX and improve accessibility behavior. |
.jules/palette.md |
Adds a learning log entry describing the empty-string reset pattern for numeric input inline validation. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
π‘ What:
target_bytesλ°batch_target_bytesμ λ ₯ νλμμ μ¬μ©μκ° κ°μ μ§μ λΉ λ¬Έμμ΄μ΄ λμμ λ 컀μ€ν μ ν¨μ± κ²μ¬ μλ¬μaria-invalidμμ±μ λͺ μμ μΌλ‘ ν΄μ νλλ‘ κ°μ νμ΅λλ€.π― Why: μ¬μ©μκ° μ«μλ₯Ό μμ νκΈ° μν΄ μ λ ₯λμ λͺ¨λ μ§μ μ λ "Must be greater than 0."λΌλ μλͺ»λ μλ¬ λ©μμ§κ° νμλμ΄ νΌλμ μ£Όλ λ¬Έμ λ₯Ό ν΄κ²°ν©λλ€. λΉ λ¬Έμμ΄μΌ κ²½μ° HTML5 κΈ°λ³Έ
requiredμμ±μ΄ μμ°μ€λ½κ² μλνλλ‘ λ³΄μ₯ν©λλ€.πΈ Before/After: λΉ λ¬Έμμ΄ μ λ ₯ μ λ μ΄μ 컀μ€ν μλ¬ ν μ€νΈλ λΉ¨κ° ν λλ¦¬κ° νμλμ§ μμ΅λλ€.
βΏ Accessibility: λΉ νλμ λν΄ μ€ν¬λ¦° 리λκ° λΆνμνκ² μ ν¨νμ§ μμ μν(
aria-invalid="true")λΌκ³ μλͺ» μ½μ΄μ£Όλ λ¬Έμ λ₯Ό λ°©μ§ν©λλ€.PR created automatically by Jules for task 10497190804455258626 started by @seonghobae