Skip to content

🎨 Palette: 숫자 μž…λ ₯ ν•„λ“œμ˜ 빈 λ¬Έμžμ—΄μ— λŒ€ν•œ μœ νš¨μ„± 검사 처리 κ°œμ„ #274

Open
seonghobae wants to merge 1 commit into
mainfrom
jules-palette-fix-empty-string-validation-10497190804455258626
Open

🎨 Palette: 숫자 μž…λ ₯ ν•„λ“œμ˜ 빈 λ¬Έμžμ—΄μ— λŒ€ν•œ μœ νš¨μ„± 검사 처리 κ°œμ„ #274
seonghobae wants to merge 1 commit into
mainfrom
jules-palette-fix-empty-string-validation-10497190804455258626

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: target_bytes 및 batch_target_bytes μž…λ ₯ ν•„λ“œμ—μ„œ μ‚¬μš©μžκ°€ 값을 μ§€μ›Œ 빈 λ¬Έμžμ—΄μ΄ λ˜μ—ˆμ„ λ•Œ μ»€μŠ€ν…€ μœ νš¨μ„± 검사 μ—λŸ¬μ™€ aria-invalid 속성을 λͺ…μ‹œμ μœΌλ‘œ ν•΄μ œν•˜λ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: μ‚¬μš©μžκ°€ 숫자λ₯Ό μˆ˜μ •ν•˜κΈ° μœ„ν•΄ μž…λ ₯λž€μ„ λͺ¨λ‘ 지웠을 λ•Œ "Must be greater than 0."λΌλŠ” 잘λͺ»λœ μ—λŸ¬ λ©”μ‹œμ§€κ°€ ν‘œμ‹œλ˜μ–΄ ν˜Όλž€μ„ μ£ΌλŠ” 문제λ₯Ό ν•΄κ²°ν•©λ‹ˆλ‹€. 빈 λ¬Έμžμ—΄μΌ 경우 HTML5 κΈ°λ³Έ required 속성이 μžμ—°μŠ€λŸ½κ²Œ μž‘λ™ν•˜λ„λ‘ 보μž₯ν•©λ‹ˆλ‹€.
πŸ“Έ Before/After: 빈 λ¬Έμžμ—΄ μž…λ ₯ μ‹œ 더 이상 μ»€μŠ€ν…€ μ—λŸ¬ ν…μŠ€νŠΈλ‚˜ λΉ¨κ°„ ν…Œλ‘λ¦¬κ°€ ν‘œμ‹œλ˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.
β™Ώ Accessibility: 빈 ν•„λ“œμ— λŒ€ν•΄ 슀크린 리더가 λΆˆν•„μš”ν•˜κ²Œ μœ νš¨ν•˜μ§€ μ•Šμ€ μƒνƒœ(aria-invalid="true")라고 잘λͺ» μ½μ–΄μ£ΌλŠ” 문제λ₯Ό λ°©μ§€ν•©λ‹ˆλ‹€.


PR created automatically by Jules for task 10497190804455258626 started by @seonghobae

- `target_bytes` 및 `batch_target_bytes` μž…λ ₯ ν•„λ“œμ—μ„œ μ‚¬μš©μžκ°€ 값을 μ§€μ›Œ 빈 λ¬Έμžμ—΄μ΄ λ˜μ—ˆμ„ λ•Œ μ»€μŠ€ν…€ μœ νš¨μ„± 검사 μ—λŸ¬μ™€ `aria-invalid` 속성을 λͺ…μ‹œμ μœΌλ‘œ ν•΄μ œν•˜λ„λ‘ κ°œμ„ 
- `.jules/palette.md` νŒŒμΌμ— 빈 λ¬Έμžμ—΄ 처리 μƒνƒœ 관리에 κ΄€ν•œ ν•™μŠ΅ λ‚΄μš© μΆ”κ°€
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 21, 2026 17:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the client-side inline validation behavior for the target_bytes and batch_target_bytes numeric inputs in saas_web.py so that when a user clears the field to an empty string, any previously-set custom validation error and aria-invalid state are explicitly resetβ€”allowing native HTML5 required validation to behave naturally and avoiding misleading β€œMust be greater than 0.” feedback.

Changes:

  • Add an explicit early-return branch for this.value === '' in both numeric input input event handlers to clear setCustomValidity, remove aria-invalid, clear the preview text, and reset preset button aria-pressed.
  • Document the β€œempty string handling” lesson and action item in .jules/palette.md for future UI validation work.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
saas_web.py Resets custom validity + ARIA invalid state on empty numeric input to prevent incorrect error UX and improve accessibility behavior.
.jules/palette.md Adds a learning log entry describing the empty-string reset pattern for numeric input inline validation.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants