Skip to content

🎨 Palette: [UX improvement] 배치 파일 μ—…λ‘œλ“œ 크기 검증 및 동적 μ—λŸ¬ λ©”μ‹œμ§€ κ°œμ„ #282

Open
seonghobae wants to merge 1 commit into
mainfrom
palette-batch-size-validation-1972778485267174059
Open

🎨 Palette: [UX improvement] 배치 파일 μ—…λ‘œλ“œ 크기 검증 및 동적 μ—λŸ¬ λ©”μ‹œμ§€ κ°œμ„ #282
seonghobae wants to merge 1 commit into
mainfrom
palette-batch-size-validation-1972778485267174059

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What

saas_web.py λ‚΄μ˜ 파일 μ—…λ‘œλ“œ 폼(단일 및 일괄 μ—…λ‘œλ“œ)μ—μ„œ ν•˜λ“œμ½”λ”©λœ '5 GiB' μ—λŸ¬ λ©”μ‹œμ§€λ₯Ό λ°±μ—”λ“œμ˜ MAX_UPLOAD_BYTES 값에 맞좰 λ™μ μœΌλ‘œ μƒμ„±λ˜λ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€. 특히, 일괄 파일 μ—…λ‘œλ“œ 폼에 λŒ€ν•΄μ„œλŠ” μ„ νƒλœ λͺ¨λ“  파일의 총 크기λ₯Ό ν•©μ‚°ν•˜μ—¬ μ„œλ²„ μ œν•œμ„ μ΄ˆκ³Όν•  경우 즉각적인 인라인 μ—λŸ¬ ν”Όλ“œλ°±μ„ μ œκ³΅ν•˜λ„λ‘ ν΄λΌμ΄μ–ΈνŠΈ 단 검증 λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

μ‚¬μš©μžκ°€ μ—¬λŸ¬ 개의 λŒ€μš©λŸ‰ νŒŒμΌμ„ 일괄 μ—…λ‘œλ“œν•  λ•Œ 총 파일 크기λ₯Ό νŒŒμ•…ν•˜μ§€ λͺ»ν•΄ μ—…λ‘œλ“œ μ œν•œμ„ μ΄ˆκ³Όν•˜κ±°λ‚˜ κΈ΄ μ—…λ‘œλ“œ λŒ€κΈ° μ‹œκ°„ 후에야 μ„œλ²„ μΈ‘ μ—λŸ¬λ₯Ό λ°œκ²¬ν•˜λŠ” λ‹΅λ‹΅ν•œ 상황을 λ°©μ§€ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€. ν”„λ‘ νŠΈμ—”λ“œ λ‹¨μ—μ„œ μ‹€μ‹œκ°„ ν”Όλ“œλ°±μ„ 쀌으둜써 μ „λ°˜μ μΈ μ‚¬μš©μ„±μ„ 크게 ν–₯μƒμ‹œν‚΅λ‹ˆλ‹€.

πŸ“Έ Before/After

Before:

  • 일괄 μ—…λ‘œλ“œ μ‹œ κ°œλ³„ 파일 크기만 ν‘œμ‹œλ˜κ³  전체 μ œν•œ 초과 μ—¬λΆ€λ₯Ό μ¦‰μ‹œ μ•Œ 수 μ—†μŒ.
  • 파일 크기 ν•œκ³„κ°€ μ—λŸ¬ λ©”μ‹œμ§€μ— '5 GiB'둜 ν•˜λ“œμ½”λ”©λ˜μ–΄ λ°±μ—”λ“œ κ°’ 변동 μ‹œ μ˜€ν•΄μ˜ μ†Œμ§€κ°€ 있음.

After:

  • λ™μ μœΌλ‘œ ν¬λ§·νŒ…λœ μ œν•œ 크기 ν…μŠ€νŠΈκ°€ 였λ₯˜ λ©”μ‹œμ§€μ— 좜λ ₯됨.
  • μ—¬λŸ¬ νŒŒμΌμ„ μ„ νƒν–ˆμ„ λ•Œ 총 파일 크기가 μ΅œλŒ€ ν•œλ„λ₯Ό λ„˜μ–΄μ„œλ©΄ ν…μŠ€νŠΈκ°€ λΆ‰κ²Œ λ³€ν•˜λ©° 즉각 μ—λŸ¬ ν…μŠ€νŠΈ(exceeds X GiB limit) 좜λ ₯.

β™Ώ Accessibility

  • μžλ°”μŠ€ν¬λ¦½νŠΈλ₯Ό μ΄μš©ν•΄ μ»€μŠ€ν…€ μ—λŸ¬ 둜직 λ°œλ™ μ‹œ setCustomValidity와 λ”λΆˆμ–΄ μ‹œκ° μž₯μ• λ₯Ό κ°€μ§„ μ‚¬μš©μžμ˜ 슀크린 λ¦¬λ”μ—μ„œ 읽힐 수 μžˆλ„λ‘ λ™μ μœΌλ‘œ aria-invalid='true' 속성을 μ™„λ²½νžˆ μ—°λ™μ‹œμΌ°μŠ΅λ‹ˆλ‹€. μ—λŸ¬ λ©”μ‹œμ§€λŠ” 뢉은색(dc3545) ν…μŠ€νŠΈλ‘œ λͺ…ν™•ν•œ μ‹œκ°μ  ν”Όλ“œλ°±μ„ μ œκ³΅ν•©λ‹ˆλ‹€.

PR created automatically by Jules for task 1972778485267174059 started by @seonghobae

- saas_web.py에 동적 ν•œκ³„ 크기(MAX_UPLOAD_BYTES) ν¬λ§·νŒ… μΆ”κ°€ν•˜μ—¬ μ—λŸ¬ λ©”μ‹œμ§€μ— ν™œμš©
- 일괄 μ—…λ‘œλ“œ μ‹œ ν΄λΌμ΄μ–ΈνŠΈ λ‹¨μ—μ„œ 총합 파일 크기λ₯Ό κ²€μ¦ν•˜μ—¬ UI에 즉각적인 ν”Όλ“œλ°±(setCustomValidity, aria-invalid) 제곡
- tests/test_saas_web.py κ°±μ‹  및 100% μ½”λ“œ 컀버리지 보μž₯
- CHANGELOG 및 .jules/palette.md μΆ”κ°€
Copilot AI review requested due to automatic review settings July 22, 2026 21:41
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the FastAPI upload UI (saas_web.py) by making the client-side upload size error messaging derive from the configured size limit constant, and by adding batch-upload total-size validation to provide immediate inline feedback when a selection exceeds the limit.

Changes:

  • Updated file-size validation messages to dynamically format the limit text from MAX_UPLOAD_BYTES instead of hardcoding 5 GiB.
  • Added client-side validation for batch uploads to reject selections whose combined file size exceeds the configured limit, with inline preview + setCustomValidity + aria-invalid.
  • Updated UI snapshot-style tests to assert the new dynamic error-message construction.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
saas_web.py Formats upload-limit text dynamically and adds total-size validation for batch file selections.
tests/test_saas_web.py Updates assertions to match the new dynamic validation/error-message strings.
CHANGELOG.md Adds an entry documenting the UX improvement.
.jules/palette.md Records a UX/accessibility learning/action note related to dynamic limit formatting and batch validation.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md
### Added
- 닀쀑 파일 μ—…λ‘œλ“œ 선택 μ‹œ 즉각적인 파일 개수 ν”Όλ“œλ°± 및 μ œν•œ 초과 κ²½κ³  λ©”μ‹œμ§€ μΆ”κ°€
- 일괄 μ—…λ‘œλ“œ 폼에 λŒ€μƒ λ°”μ΄νŠΈ 프리셋 λ²„νŠΌκ³Ό 총 파일 크기 미리보기λ₯Ό μΆ”κ°€ν•˜μ—¬ μ‚¬μš©μ„±μ„ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
* 🎨 Palette: [UX improvement] 배치 μ—…λ‘œλ“œ μ‹œ 전체 파일 크기 검증 μΆ”κ°€ 및 동적 μ—λŸ¬ λ©”μ‹œμ§€ ν¬λ§·νŒ… 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants