๐จ Palette: ๋น ์ซ์ ์ ๋ ฅ ํ๋์ ์ธ๋ผ์ธ ์ ํจ์ฑ ๊ฒ์ฌ ์ฒ๋ฆฌ ๊ฐ์ #283
๐จ Palette: ๋น ์ซ์ ์
๋ ฅ ํ๋์ ์ธ๋ผ์ธ ์ ํจ์ฑ ๊ฒ์ฌ ์ฒ๋ฆฌ ๊ฐ์ #283seonghobae wants to merge 1 commit into
Conversation
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the client-side inline validation behavior for the SaaS web UIโs target_bytes and batch_target_bytes numeric inputs so that clearing the field (empty string) fully resets any previously-set custom validity errors and aria-invalid state, avoiding โstuck invalidโ browser constraint behavior.
Changes:
- Reset
setCustomValidity('')/ removearia-invalidand clear preview output when the numeric input is emptied for both single and batch forms. - Document the validation-reset learning/action in the Palette guidance notes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
saas_web.py |
Adds explicit empty-string handling in JS input listeners to clear custom validity + aria-invalid and reset preview output. |
.jules/palette.md |
Records the rationale and the recommended pattern for clearing custom validity/aria-invalid on empty numeric inputs. |
Comments suppressed due to low confidence (1)
saas_web.py:297
- Same as the single-upload form: the new empty-string reset path for batch_target_bytes should be covered by a UI HTML test assertion (e.g., verify the rendered page contains the
if (this.value === '') { ... }block for batch_target_bytes). This helps prevent future changes from reintroducing the stuck custom-validity/aria-invalid state.
if (this.value === '') {
preview.innerText = '';
this.setCustomValidity('');
this.removeAttribute('aria-invalid');
return;
}
๐ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (this.value === '') { | ||
| preview.innerText = ''; | ||
| this.setCustomValidity(''); | ||
| this.removeAttribute('aria-invalid'); | ||
| return; | ||
| } |
๐ก What:
target_bytes๋ฐbatch_target_bytes์ ๋ ฅ ํ๋์์ ๊ฐ์ด ๋น ๋ฌธ์์ด๋ก ์ง์์ก์ ๋ ๊ธฐ์กด์ ๋ฐ์ํ๋ ์ปค์คํ ์ ํจ์ฑ ๊ฒ์ฌ ์ค๋ฅ ๋ฐaria-invalid์ํ๋ฅผ ๋ช ์์ ์ผ๋ก ํด์ ํ๋๋ก JavaScript ์ด๋ฒคํธ ๋ฆฌ์ค๋๋ฅผ ๊ฐ์ ํ์ต๋๋ค.๐ฏ Why: ์ฌ์ฉ์๊ฐ ์ ํจํ์ง ์์ ๊ฐ(์: ์์)์ ์ ๋ ฅํ ํ ๋ฐฑ์คํ์ด์ค๋ก ๊ฐ์ ์ง์ ์ ๋, ์๊ฐ์ ํ ์คํธ๋ ์ง์์ก์ง๋ง ๋ธ๋ผ์ฐ์ ๋ด๋ถ์ ์ ํจํ์ง ์์ ์ํ๊ฐ ๋จ์ ์์ด ํผ ์ ์ถ์ด๋ ๊ธฐ๋ณธ HTML5
required๋์์ด ์ฌ๋ฐ๋ฅด๊ฒ ์ด๋ฃจ์ด์ง์ง ์๊ฑฐ๋ ์๋ชป๋ ์ค๋ฅ ๋ฉ์์ง๊ฐ ํ์๋๋ ๋ฌธ์ ๋ฅผ ํด๊ฒฐํ๊ธฐ ์ํจ์ ๋๋ค.๐ธ Before/After: ํด๋น ์์ (์๊ฐ์ ๋ณ๊ฒฝ ์์, ๋์ ์์ ์ฑ ๊ฐ์ )
โฟ Accessibility: ๋น ์ํ์์ ๋ถํ์ํ๊ฒ ์คํฌ๋ฆฐ ๋ฆฌ๋์ ์ค๋ฅ ์ํ(
aria-invalid="true")๊ฐ ๋จ์์๋ ๋ฌธ์ ๋ฅผ ํด๊ฒฐํ์ฌ ์ ๊ทผ์ฑ์ ํฅ์์์ผฐ์ต๋๋ค.PR created automatically by Jules for task 18190623459465020740 started by @seonghobae