Skip to content

๐ŸŽจ Palette: ๋นˆ ์ˆซ์ž ์ž…๋ ฅ ํ•„๋“œ์˜ ์ธ๋ผ์ธ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ์ฒ˜๋ฆฌ ๊ฐœ์„ #283

Open
seonghobae wants to merge 1 commit into
mainfrom
fix-numeric-validation-empty-string-18190623459465020740
Open

๐ŸŽจ Palette: ๋นˆ ์ˆซ์ž ์ž…๋ ฅ ํ•„๋“œ์˜ ์ธ๋ผ์ธ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ์ฒ˜๋ฆฌ ๊ฐœ์„ #283
seonghobae wants to merge 1 commit into
mainfrom
fix-numeric-validation-empty-string-18190623459465020740

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What: target_bytes ๋ฐ batch_target_bytes ์ž…๋ ฅ ํ•„๋“œ์—์„œ ๊ฐ’์ด ๋นˆ ๋ฌธ์ž์—ด๋กœ ์ง€์›Œ์กŒ์„ ๋•Œ ๊ธฐ์กด์— ๋ฐœ์ƒํ–ˆ๋˜ ์ปค์Šคํ…€ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ์˜ค๋ฅ˜ ๋ฐ aria-invalid ์ƒํƒœ๋ฅผ ๋ช…์‹œ์ ์œผ๋กœ ํ•ด์ œํ•˜๋„๋ก JavaScript ์ด๋ฒคํŠธ ๋ฆฌ์Šค๋„ˆ๋ฅผ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ์‚ฌ์šฉ์ž๊ฐ€ ์œ ํšจํ•˜์ง€ ์•Š์€ ๊ฐ’(์˜ˆ: ์Œ์ˆ˜)์„ ์ž…๋ ฅํ•œ ํ›„ ๋ฐฑ์ŠคํŽ˜์ด์Šค๋กœ ๊ฐ’์„ ์ง€์› ์„ ๋•Œ, ์‹œ๊ฐ์  ํ…์ŠคํŠธ๋Š” ์ง€์›Œ์กŒ์ง€๋งŒ ๋ธŒ๋ผ์šฐ์ € ๋‚ด๋ถ€์— ์œ ํšจํ•˜์ง€ ์•Š์€ ์ƒํƒœ๊ฐ€ ๋‚จ์•„ ์žˆ์–ด ํผ ์ œ์ถœ์ด๋‚˜ ๊ธฐ๋ณธ HTML5 required ๋™์ž‘์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ด๋ฃจ์–ด์ง€์ง€ ์•Š๊ฑฐ๋‚˜ ์ž˜๋ชป๋œ ์˜ค๋ฅ˜ ๋ฉ”์‹œ์ง€๊ฐ€ ํ‘œ์‹œ๋˜๋Š” ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ํ•ด๋‹น ์—†์Œ (์‹œ๊ฐ์  ๋ณ€๊ฒฝ ์—†์Œ, ๋™์ž‘ ์•ˆ์ •์„ฑ ๊ฐœ์„ )
โ™ฟ Accessibility: ๋นˆ ์ƒํƒœ์—์„œ ๋ถˆํ•„์š”ํ•˜๊ฒŒ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์— ์˜ค๋ฅ˜ ์ƒํƒœ(aria-invalid="true")๊ฐ€ ๋‚จ์•„์žˆ๋Š” ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜์—ฌ ์ ‘๊ทผ์„ฑ์„ ํ–ฅ์ƒ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 18190623459465020740 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 23, 2026 17:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the client-side inline validation behavior for the SaaS web UIโ€™s target_bytes and batch_target_bytes numeric inputs so that clearing the field (empty string) fully resets any previously-set custom validity errors and aria-invalid state, avoiding โ€œstuck invalidโ€ browser constraint behavior.

Changes:

  • Reset setCustomValidity('') / remove aria-invalid and clear preview output when the numeric input is emptied for both single and batch forms.
  • Document the validation-reset learning/action in the Palette guidance notes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
saas_web.py Adds explicit empty-string handling in JS input listeners to clear custom validity + aria-invalid and reset preview output.
.jules/palette.md Records the rationale and the recommended pattern for clearing custom validity/aria-invalid on empty numeric inputs.
Comments suppressed due to low confidence (1)

saas_web.py:297

  • Same as the single-upload form: the new empty-string reset path for batch_target_bytes should be covered by a UI HTML test assertion (e.g., verify the rendered page contains the if (this.value === '') { ... } block for batch_target_bytes). This helps prevent future changes from reintroducing the stuck custom-validity/aria-invalid state.
                if (this.value === '') {
                    preview.innerText = '';
                    this.setCustomValidity('');
                    this.removeAttribute('aria-invalid');
                    return;
                }

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread saas_web.py
Comment on lines +258 to +263
if (this.value === '') {
preview.innerText = '';
this.setCustomValidity('');
this.removeAttribute('aria-invalid');
return;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants