π¨ Palette: λΉ λλ ν 리 μν λ©μμ§μ role="status" μΆκ°#236
π¨ Palette: λΉ λλ ν 리 μν λ©μμ§μ role="status" μΆκ°#236seonghobae wants to merge 1 commit into
Conversation
λΉ λλ ν 리λ₯Ό λνλ΄λ μν λ©μμ§μ `role="status"`λ₯Ό μΆκ°νμ¬ μ€ν¬λ¦° 리λ μ¬μ©μκ° μ΄λ₯Ό λ¨μ ν μ€νΈκ° μλ μν λ³νλ‘ μΈμ§ν μ μλλ‘ μ κ·Όμ±μ κ°μ νμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Adds ARIA semantics to the generated empty-directory message so assistive technologies can recognize it as a status message, and updates tests/docs accordingly.
Changes:
- Add
role="status"to the empty-directory message element in generatedindex.html. - Extend
MainTest.testGoEmptyDirto assert the new ARIA role is present. - Document the accessibility rationale/action in
.jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/html4tree/main.kt | Adds role="status" to the empty-state message markup when a directory listing is empty. |
| src/test/kotlin/html4tree/MainTest.kt | Updates the empty-directory test to check for the new role attribute in generated HTML. |
| .jules/palette.md | Records the accessibility learning/action for adding role="status" to empty-state messaging. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| val htmlContent = indexFile.readText() | ||
| assertTrue(htmlContent.contains("<html lang=\"ko\">")) | ||
| assertTrue(htmlContent.contains("μ΄ λλ ν 리λ λΉμ΄ μμ΅λλ€.")) | ||
| assertTrue(htmlContent.contains("role=\"status\"")) |
π‘ What: μμ±λ λλ ν 리 νΈλ¦¬μ "μ΄ λλ ν 리λ λΉμ΄ μμ΅λλ€." μν λ©μμ§μ
role="status"μμ±μ μΆκ°νμ΅λλ€.π― Why: κΈ°μ‘΄ λ©μμ§λ μκ°μ μΌλ‘λ ꡬλ³λλ μ€ν¬λ¦° 리λμμλ λ¨μ ν μ€νΈλ‘ μ½κ³ λμ΄κ° μ μμ΄, λΉ μν(Empty State)λΌλ 컨ν μ€νΈλ₯Ό μ λλ‘ μ λ¬νκΈ° μν¨μ λλ€.
πΈ Before/After:
<div class="empty-dir">μ΄ λλ ν 리λ λΉμ΄ μμ΅λλ€.</div><div class="empty-dir" role="status">μ΄ λλ ν 리λ λΉμ΄ μμ΅λλ€.</div>βΏ Accessibility: μ€ν¬λ¦° 리λκ° ν΄λΉ μμλ₯Ό μν λ©μμ§λ‘ μ¬λ°λ₯΄κ² μΈμνκ³ μ¬μ©μμκ² μλ΄ν μ μλλ‘ ν₯μλμμ΅λλ€.
PR created automatically by Jules for task 17219880337230985203 started by @seonghobae