Skip to content

🎨 Palette: 빈 디렉토리 μƒνƒœ λ©”μ‹œμ§€μ— role="status" μΆ”κ°€#236

Open
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-dir-status-17219880337230985203
Open

🎨 Palette: 빈 디렉토리 μƒνƒœ λ©”μ‹œμ§€μ— role="status" μΆ”κ°€#236
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-dir-status-17219880337230985203

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: μƒμ„±λœ 디렉토리 트리의 "이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€." μƒνƒœ λ©”μ‹œμ§€μ— role="status" 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: κΈ°μ‘΄ λ©”μ‹œμ§€λŠ” μ‹œκ°μ μœΌλ‘œλŠ” κ΅¬λ³„λ˜λ‚˜ 슀크린 λ¦¬λ”μ—μ„œλŠ” λ‹¨μˆœ ν…μŠ€νŠΈλ‘œ 읽고 λ„˜μ–΄κ°ˆ 수 μžˆμ–΄, 빈 μƒνƒœ(Empty State)λΌλŠ” μ»¨ν…μŠ€νŠΈλ₯Ό μ œλŒ€λ‘œ μ „λ‹¬ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.
πŸ“Έ Before/After:

  • Before: <div class="empty-dir">이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€.</div>
  • After: <div class="empty-dir" role="status">이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€.</div>
    β™Ώ Accessibility: 슀크린 리더가 ν•΄λ‹Ή μš”μ†Œλ₯Ό μƒνƒœ λ©”μ‹œμ§€λ‘œ μ˜¬λ°”λ₯΄κ²Œ μΈμ‹ν•˜κ³  μ‚¬μš©μžμ—κ²Œ μ•ˆλ‚΄ν•  수 μžˆλ„λ‘ ν–₯μƒλ˜μ—ˆμŠ΅λ‹ˆλ‹€.

PR created automatically by Jules for task 17219880337230985203 started by @seonghobae

빈 디렉토리λ₯Ό λ‚˜νƒ€λ‚΄λŠ” μƒνƒœ λ©”μ‹œμ§€μ— `role="status"`λ₯Ό μΆ”κ°€ν•˜μ—¬ 슀크린 리더 μ‚¬μš©μžκ°€ 이λ₯Ό λ‹¨μˆœ ν…μŠ€νŠΈκ°€ μ•„λ‹Œ μƒνƒœ λ³€ν™”λ‘œ 인지할 수 μžˆλ„λ‘ 접근성을 κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
Copilot AI review requested due to automatic review settings July 21, 2026 20:59
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ARIA semantics to the generated empty-directory message so assistive technologies can recognize it as a status message, and updates tests/docs accordingly.

Changes:

  • Add role="status" to the empty-directory message element in generated index.html.
  • Extend MainTest.testGoEmptyDir to assert the new ARIA role is present.
  • Document the accessibility rationale/action in .jules/palette.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/main/kotlin/html4tree/main.kt Adds role="status" to the empty-state message markup when a directory listing is empty.
src/test/kotlin/html4tree/MainTest.kt Updates the empty-directory test to check for the new role attribute in generated HTML.
.jules/palette.md Records the accessibility learning/action for adding role="status" to empty-state messaging.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

val htmlContent = indexFile.readText()
assertTrue(htmlContent.contains("<html lang=\"ko\">"))
assertTrue(htmlContent.contains("이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€."))
assertTrue(htmlContent.contains("role=\"status\""))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants