🛡️ Sentinel: [CRITICAL] Fix missing control character validation in Pydantic models

[seonghobae]

🚨 Severity: CRITICAL
💡 Vulnerability: User-provided string fields lacked strict validation against control characters, only relying on length constraints.
🎯 Impact: Unvalidated control characters could lead to Log Injection (CRLF injection), Null Byte Injection, or terminal escape injection if these strings are subsequently logged or rendered directly.
🔧 Fix: Added explicit regex validation pattern=r'^[^\x00-\x1F\x7F]+$' on missing Pydantic string fields to strictly reject control characters.
✅ Verification: Added comprehensive pytest test cases for all patched Pydantic models to ensure validation correctly rejects \n and \x00. All tests passed.

---

PR created automatically by Jules for task 14649349373423149537 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 268a26e6-cbec-4ab4-9f47-f593c052e455

📥 Commits

Reviewing files that changed from the base of the PR and between 4bf3968 and 28598ba.

📒 Files selected for processing (2)

• backend/app/schemas.py
• backend/tests/test_schema_validation.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-pydantic-validation-14649349373423149537

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR hardens backend request-schema validation by ensuring user-provided “name-like” fields in Pydantic input models reject ASCII control characters, mitigating CRLF/log injection and related control-character attacks.

Changes:

• Added pattern=r"^[^\x00-\x1F\x7F]+$" validation to DiagramViewCreateIn.name, TableAnnotationUpsertIn.schema_name/relation_name, and ApiKeyCreateIn.key_name.
• Expanded schema validation tests to cover the newly hardened models and ensure \x00 and \n are rejected.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
backend/app/schemas.py	Adds control-character rejection regex to additional user-provided string fields in request schemas.
backend/tests/test_schema_validation.py	Adds pytest coverage asserting the new regex constraints reject NUL and newline characters.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.