⚡ Bolt: Optimize Array .find() in ERD Export DDL#660
Conversation
This commit optimizes a nested array linear search (`Array.find()`) inside the `exportDDL` graph loop which searches for matching source/target handle IDs against node columns. By precomputing an `O(1)` Map that caches handle IDs for the nodes on demand, it converts an `O(E * C)` algorithm constraint to an `O(N * C + E)` lookup constraint, providing significant performance speedups for large entity relationship diagram exports.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR optimizes frontend ERD DDL export performance by eliminating repeated per-edge linear scans for handle→column resolution. It introduces an on-demand per-node handle map cache and allows fkColumnsForEdge to use Map lookups for amortized O(1) resolution during the edge traversal.
Changes:
- Extended
fkColumnsForEdgeto optionally resolve columns via precomputed handle maps. - Added an on-demand
handleMapCacheinexportDDLto avoid repeatedArray.find()work inside the edges loop. - Documented the optimization in
.jules/bolt.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/erd/export.ts | Adds per-node handle→column map caching and map-based lookups to reduce DDL export complexity on large graphs. |
| .jules/bolt.md | Records the performance learning/action for the DDL export optimization. |
Comments suppressed due to low confidence (1)
frontend/src/erd/export.ts:154
targetMapis initialized withnew Map()without type parameters, which widens the map toMap<any, any>and weakens type-safety for the cached handle→column mapping. Use an explicitMap<string, string>to keep the cache strongly typed.
if (!targetMap) {
targetMap = new Map();
for (const c of targetNode.data.columns || []) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (!sourceMap) { | ||
| sourceMap = new Map(); | ||
| for (const c of sourceNode.data.columns || []) { |
💡 What: Refactored
fkColumnsForEdgeto optionally accept Map representations for handle-to-column resolutions and implemented an on-demandhandleMapCachemechanism inexportDDL.🎯 Why: Iterating over every column array (
.find()) inside the main edge iterator loop creates a severe O(N^2) complexity bottleneck, generating unnecessary load and hurting the DDL generation performance for large relational graphs.📊 Impact: Considerably faster DDL export scaling via amortized
O(1)handle lookups, skipping excessive array scans during graph traversal.🔬 Measurement: Verify export functionality via
pnpm run test(all export tests pass indicating correctness). Local profiling confirms execution time on large datasets improves significantly.PR created automatically by Jules for task 8068459442034218263 started by @seonghobae