🎨 Palette: [UX improvement] 모달 버튼들의 aria-label 추가로 스크린 리더 접근성 개선 by seonghobae · Pull Request #661 · ContextualWisdomLab/pg-erd-cloud

seonghobae · 2026-07-27T02:23:42Z

💡 What: EditEdgeModal과 EditTableModal 내부의 버튼("삭제", "취소", "저장", "복제" 등)에 컨텍스트 정보를 포함한 aria-label을 추가했습니다. (예: aria-label="test_table 테이블 삭제") 관련 프론트엔드 테스트 코드(EditTableModal.test.tsx, ModalCoverage.test.tsx) 또한 변경된 aria-label에 맞춰 검증하도록 수정했습니다.
🎯 Why: 일반적인 "삭제", "저장" 버튼은 스크린 리더로 접근했을 때 문맥이 부족하여 사용자가 어떤 데이터를 변경하는지 인지하기 어렵습니다. 이를 개선하여 모달의 접근성을 높이기 위함입니다.
♿ Accessibility: 액션 버튼에 동적 데이터를 주입한 aria-label 추가로 스크린 리더 내비게이션 명확성 개선.

PR created automatically by Jules for task 13596676413572164701 started by @seonghobae

* 모달(`EditEdgeModal`, `EditTableModal`) 내 일반적인 목적의 버튼(삭제, 취소, 저장, 복제)에 동적인 `aria-label` 추가 * 스크린 리더 사용자가 해당 버튼이 어떤 컨텍스트에서 동작하는지 명확히 인지할 수 있도록 컨텍스트 정보 포함 * 관련 프론트엔드 테스트 코드 업데이트 및 통과 확인

google-labs-jules · 2026-07-27T02:23:43Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

coderabbitai · 2026-07-27T02:23:50Z

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b4aac0e0-0247-41b3-ab3c-7eb1ed9fa6de

📥 Commits

Reviewing files that changed from the base of the PR and between 4bf3968 and 3e191f4.

📒 Files selected for processing (5)

.jules/palette.md
frontend/src/components/modals/EditEdgeModal.tsx
frontend/src/components/modals/EditTableModal.test.tsx
frontend/src/components/modals/EditTableModal.tsx
frontend/src/components/modals/ModalCoverage.test.tsx

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch jules-13596676413572164701-ad23a990

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Pull request overview

Adds more descriptive, context-aware accessible names for modal action buttons so screen reader users can distinguish generic actions (삭제/저장/취소/복제) by the table/relationship context, and updates tests and the palette log accordingly.

Changes:

Add contextual aria-label attributes to action buttons in EditEdgeModal and EditTableModal.
Update modal-related frontend tests to assert against the new accessible button names.
Record the accessibility learning/action in .jules/palette.md.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
frontend/src/components/modals/ModalCoverage.test.tsx	Updates role/name queries to match new contextual aria-label accessible names.
frontend/src/components/modals/EditTableModal.tsx	Adds contextual aria-labels for delete/duplicate/save/cancel actions in the table edit modal.
frontend/src/components/modals/EditTableModal.test.tsx	Updates the duplication test to click by the new contextual accessible name.
frontend/src/components/modals/EditEdgeModal.tsx	Adds contextual aria-labels for delete/save/cancel actions in the edge edit modal.
.jules/palette.md	Documents the new accessibility guideline/learning for modal button labeling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+            <button type="button" onClick={onEditTableCancel} aria-label="테이블 편집 취소">취소</button>
            <button
              type="submit"
              form="editTableForm"
              style={{ background: "#034ea2", color: "#fff" }}
+              aria-label={`${editingNode.data.title} 테이블 저장`}
            >


+## 2026-07-27 - [Descriptive ARIA labels for modal buttons]
+**Learning:** Adding dynamic, contextual `aria-label` attributes to generic buttons (like Save, Cancel, Delete) inside modals significantly improves screen reader navigation and clarity, ensuring users understand exactly what action they are taking.
+**Action:** Always provide contextual `aria-label`s for generic action buttons in dialogs using dynamic data like node or edge names.


Copilot AI review requested due to automatic review settings July 27, 2026 02:23

Copilot started reviewing on behalf of seonghobae July 27, 2026 02:24 View session

Copilot AI reviewed Jul 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🎨 Palette: [UX improvement] 모달 버튼들의 aria-label 추가로 스크린 리더 접근성 개선#661

🎨 Palette: [UX improvement] 모달 버튼들의 aria-label 추가로 스크린 리더 접근성 개선#661
seonghobae wants to merge 1 commit into
mainfrom
jules-13596676413572164701-ad23a990

seonghobae commented Jul 27, 2026

Uh oh!

google-labs-jules Bot commented Jul 27, 2026

Uh oh!

coderabbitai Bot commented Jul 27, 2026

Review limit reached

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

seonghobae commented Jul 27, 2026

Uh oh!

google-labs-jules Bot commented Jul 27, 2026

Uh oh!

coderabbitai Bot commented Jul 27, 2026

Review limit reached

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants