Repository navigation
Trunk-based pipeline: release on a GitHub Release; fix Microsoft.OpenApi.Readers advisory - #73
Merged
Merged
Conversation
…-hqj2 - build.yml: every pull request and push to main restores, builds the library and all examples, and packs a 0.0.0-ci.* artifact. Nothing is published; the job name `build` is the required check. - publish.yml replaces release.yml: runs on a published GitHub Release, only for tomasr78, checks the SemVer tag, the pre-release tick, that a stable version is on main and has never been on nuget.org, packs with -p:Version from the tag and pushes without --skip-duplicate. Ready for nuget.org Trusted Publishing via the NUGET_USER variable. - Actions pinned to commit SHAs, SDK pinned to the 10.0.4xx band. - Version is a 0.0.0-local placeholder in the csproj; high and critical NuGet advisories (direct or transitive) now fail the build. - Microsoft.OpenApi.Readers 1.6.23 -> 1.6.31 (patched in 1.6.30). - Package metadata: repository URL, description, release notes, snupkg. - Remove the unused Dockerfile publish path (.NET Core 3.1 SDK image). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the library from GitFlow (
develop→master, hand-made "build 3.1.x" commits, tags pushed by hand) to trunk-based development on a singlemain, where merging builds but never publishes. A release is a GitHub Releasev{semver}, because nuget.org versions are public and permanent. The first release through it is v3.1.19, which carries the security fix below.Security fix
Microsoft.OpenApi.Readers1.6.23 → 1.6.31 (GHSA-7pxr-59rr-hqj2, high: YAML alias-expansion DoS, patched in 1.6.30). It is the parser behindConverterCatalogandGetConverterInfo, so it stays. Checked against the live/info/openapi: the catalog's full output (328 converters, 29 tags, search results) is byte-identical between 1.6.23 and 1.6.31. The nuspec diff against the published 3.1.18 shows only the version, the dependency, and the metadata changes listed below.Pipeline
build.yml(new, jobbuild= the required check): on every PR tomainand every push tomain, it restores, builds the library and all 21 examples, and packsConvertApi 0.0.0-ci.{run}.g{sha}as a 14-day artifact. Nothing is published.publish.yml(replacesrelease.yml): runs onrelease: publishedin thenugetenvironment.v3.1.19,v3.2.0-preview.1). The pre-release tick must match the version.main. Pre-releases may come from any branch.-p:Version=${tag#v}, checks that the nupkg records the version and the commit, and pushes without--skip-duplicate. Then it waits until nuget.org serves the package.NUGET_USERswitches from theNUGET_API_KEYsecret toNuGet/login(OIDC).checkout@master/setup-dotnet@v1.global.jsonpins the SDK to the 10.0.4xx band, patch roll-forward only.NU1903/NU1904as errors). This PR'sMicrosoft.OpenApi.Readers1.6.23 fails exactly that way.0.0.0-localplaceholder.GeneratePackageOnBuild,AssemblyVersion,FileVersionandPackageVersionare gone, because they come from the tag.Dockerfile, an old manual publish path on the .NET Core 3.1 SDK image.Package metadata
RepositoryUrlnow points toconvertapi-library-dotnet..snupkgsymbol package is published alongside.convertapi-library-dotnet/tree/main.Repository changes that go with it (separate, need Tomas's OK)
master→mainrename (GitHub redirects the webtree/masterlinks used by ca-web docs); deletedevelopandrelease/3.1.6(neither has commits outsidemaster); repo ruleset formain(merge commits only,buildrequired, admin bypass);v*tag ruleset (admins only);nugetenvironment limited tov*tags.build.ymltriggers onmain, so the check first runs oncemasteris renamed and this PR is retargeted.See
RELEASING.mdfor how to release.🤖 Generated with Claude Code