Repository navigation
3.2.0: drop netcoreapp3.1, examples on net10.0, Dependabot - #75
Merged
Merged
Conversation
- ConvertApi.csproj targets netstandard2.0 only; .NET Core 3.1 is out of support and the library has no netcoreapp3.1-specific code. - Examples move from net6.0/net8.0 to net10.0; SplitPDF now builds against the library in this repository instead of the ConvertApi 3.1.2 package. - .github/dependabot.yml: weekly github-actions and nuget updates. - CHANGELOG: unreleased 3.2.0 entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified, and the focused configuration changes align with the existing SDK, build, and release workflows.
0 open findings
What changed in this PR
Prepares 3.2.0 by simplifying library targeting, modernizing examples, and automating dependency updates. Publishing remains a separate release step.
Changes:
- Targets the library solely at
netstandard2.0. - Moves all 21 examples to
net10.0; SplitPDF now references the local library. - Adds weekly Dependabot updates and an unreleased changelog entry.
| File | Description |
|---|---|
| Examples/Workflow/Workflow.csproj | Targets .NET 10. |
| Examples/WatermarkPdf/WatermarkPdf.csproj | Targets .NET 10. |
| Examples/UploadOnceReuseTwice/UploadOnceReuseTwice.csproj | Targets .NET 10. |
| Examples/SplitPDF/SplitPDF.csproj | Targets .NET 10 and references the local library. |
| Examples/SplitAndMergePdf/SplitAndMergePdf.csproj | Targets .NET 10. |
| Examples/RetrieveUserInformation/RetrieveUserInformation.csproj | Targets .NET 10. |
| Examples/MergeWordDocsToPdf/MergeWordDocsToPdf.csproj | Targets .NET 10. |
| Examples/HandleRetry/HandleRetry.csproj | Targets .NET 10. |
| Examples/GetConverterInfoDemo/GetConverterInfoDemo.csproj | Targets .NET 10. |
| Examples/FromStreamToStream/FromStreamToStream.csproj | Targets .NET 10. |
| Examples/ExceptionHandling/ExceptionHandling.csproj | Targets .NET 10. |
| Examples/DeleteFiles/DeleteFiles.csproj | Targets .NET 10. |
| Examples/CreatePdfThumbnail/CreatePdfThumbnail.csproj | Targets .NET 10. |
| Examples/ConvertWordToPdfAndPng/ConvertWordToPdfAndPng.csproj | Targets .NET 10. |
| Examples/ConvertUrlToPdf/ConvertUrlToPdf.csproj | Targets .NET 10. |
| Examples/ConvertRemoteFile/ConvertRemoteFile.csproj | Targets .NET 10. |
| Examples/ConvertPdfToXlsx/ConvertPdfToXlsx.csproj | Targets .NET 10. |
| Examples/ConvertPdfToPptx/ConvertPdfToPptx.csproj | Targets .NET 10. |
| Examples/ConvertPdfToPdfA/ConvertPdfToPdfA.csproj | Targets .NET 10. |
| Examples/ConvertPdfToDocx/ConvertPdfToDocx.csproj | Targets .NET 10. |
| Examples/ConverterCatalogDemo/ConverterCatalogDemo.csproj | Targets .NET 10. |
| ConvertApi/ConvertApi.csproj | Removes the netcoreapp3.1 target. |
| CHANGELOG.md | Documents unreleased 3.2.0 changes. |
| .github/dependabot.yml | Schedules grouped Actions and NuGet updates. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares 3.2.0. Merging publishes nothing; the release is a separate GitHub Release (see
RELEASING.md).Changes
ConvertApi.csprojtargetsnetstandard2.0only (wasnetstandard2.0;netcoreapp3.1). .NET Core 3.1 has been out of support since Dec 2022. There is no#if/ TFM-specific code anywhere in the library, so both builds were the same code; the public API is unchanged. Packed locally: the nupkg now has a singlelib/netstandard2.0/ConvertApi.dlland one.NETStandard2.0dependency group (Microsoft.OpenApi.Readers 1.6.31, Newtonsoft.Json 13.0.1). Consumers on .NET Core 3.1 resolve thenetstandard2.0build instead. Dropping a TFM is consumer-visible, hence a minor version.net10.0(LTS, supported to Nov 2028). 20 were onnet6.0andSplitPDFwas onnet8.0(EOL 2026-11-10).SplitPDFalso referenced theConvertApi3.1.2 NuGet package instead of the library in this repo, so it was not testing the code being built, and Dependabot would have kept bumping it; it now uses aProjectReferencelike the others..github/dependabot.yml: weekly (Monday) updates forgithub-actions(the SHA pins and their# vX.Y.Zcomments, grouped into one PR) andnuget(root →ConvertApi.sln, minor and patch grouped, majors separate). PRs are labelleddependencies, go through the requiredbuildcheck, and are merged with a merge commit like any other PR. Note that a NuGet bump inConvertApi.csprojraises the minimum dependency version every consumer gets, so it should be noted in the CHANGELOG of the next release.CHANGELOG.md:[3.2.0] — Unreleasedentry.Checked
dotnet restore/dotnet build ConvertApi.sln -c Release/dotnet packlocally with SDK 10.0.401: succeeds, no new warnings (3 existing warnings in ConverterCatalogDemo and GetConverterInfoDemo).Open question (not changed here)
PackageLicenseUrl/PackageIconUrlare deprecated NuGet metadata (NuGet shows a warning and nuget.org displays the licence as a URL to the website terms). The repo'sLICENSEfile is MIT-style; whether the package should declare<PackageLicenseExpression>MIT</PackageLicenseExpression>(orPackageLicenseFile) and ship an embeddedPackageIconis a licensing decision for @tomasr78, so it is left as is.Follow-ups (not in this PR)
netstandard2.0package needs .NET Framework 4.6.2+ (the package description already says so).After merge
Release, when decided (typed by Tomas):
🤖 Generated with Claude Code