Repository navigation
Publish the tarball by a ./ path - #28
Merged
Merged
Conversation
…b shorthand npm publish "out/convertapi-js-1.1.10.tgz" failed: npm treats "owner/repo"-shaped specs as GitHub repos and tried git ls-remote ssh://git@github.com/out/... (v1.1.10 publish run 39426331326). Same fix as convertapi-library-node#107. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The recovery plan must change because rerunning the failed release uses the original workflow without this fix.
1 open issue
What changed in this PR
Corrects npm publishing so the packaged tarball is treated as a local file rather than a GitHub repository shorthand.
Changes:
- Prefixes the tarball path with
./, leaving publish flags unchanged.
| File | Description |
|---|---|
.github/workflows/publish.yml |
Makes the npm publish tarball path explicitly local. |
Review effort: Balanced
| VERSION: ${{ steps.tag.outputs.version }} | ||
| DIST_TAG: ${{ steps.tag.outputs.dist-tag }} | ||
| run: npm publish "out/$PACKAGE-$VERSION.tgz" --provenance --access public --tag "$DIST_TAG" --ignore-scripts | ||
| run: npm publish "./out/$PACKAGE-$VERSION.tgz" --provenance --access public --tag "$DIST_TAG" --ignore-scripts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.1.10 publish (https://github.com/ConvertAPI/convertapi-library-js/actions/runs/39426331326) failed at
npm publish "out/convertapi-js-1.1.10.tgz": npm reads anowner/repo-shaped spec as a GitHub shorthand and rangit ls-remote ssh://git@github.com/out/convertapi-js-1.1.10.tgz.git. Prefixing./makes it a local file. Same fix as ConvertAPI/convertapi-library-node#107.Everything before the upload passed (publisher check, version, build, tests, package check), so after merge the v1.1.10 publish run is re-run.
🤖 Generated with Claude Code