Repository navigation
Retry tests and examples on staging API 503s - #102
Merged
Merged
Conversation
stag-v2 answers about one request in ten with 503 "no healthy upstream" (gateway kaulas), which failed the first build of main. Each mocha test now gets two retries and the examples up to three attempts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Nonzero example-process exits terminate the step before warnings or retries can run.
1 open issue
What changed in this PR
Adds retries to reduce CI failures caused by intermittent staging API errors.
Changes:
- Preserves linting and adds two test retries in both workflows.
- Adds up to three example attempts, with warnings and 10-second delays.
| File | Description |
|---|---|
.github/workflows/publish.yml |
Adds test retries before publishing. |
.github/workflows/build.yml |
Adds test and example retries. |
Review effort: Balanced
Comment on lines
+78
to
+79
| node --require ./.github/examples-base-uri.js examples/ 2>&1 | tee examples.log | ||
| if ! grep -q '^Error' examples.log; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first build of main after #96 failed: the staging API (stag-v2.convertapi.com, gateway
kaulas) returns a 19-byte 503 no healthy upstream on about one request in ten. I reproduced it locally onpdf/to/jpg. See https://github.com/ConvertAPI/convertapi-library-node/actions/runs/39389655665.--retries 2, in both build.yml and publish.yml.The staging 503s themselves are an infrastructure issue and need a separate fix.
🤖 Generated with Claude Code