Point removed issue references at live ones - #280
Open
NathanTarbert wants to merge 1 commit into
Open
NathanTarbert wants to merge 1 commit into
NathanTarbert wants to merge 1 commit into
Conversation
Two strings in the templates screen sent readers to an issue that no longer exists. They now point at #279, which tracks the same gap: saved overrides never reach outgoing email. The middleware comment and its test described the ordering guarantee by issue number rather than by behaviour, so they now state it directly. Same for the template test docblocks and describe names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two strings on the templates screen told readers to see an issue that no longer exists, so the explanation dead-ended at a 404. They now point at #279, which tracks the same gap — saved overrides never reach outgoing email.
The
middleware.tscomment and its test identified the ordering guarantee by issue number rather than by behaviour. Both now state it directly, which reads better anyway and does not depend on an issue surviving. Same change for the template test docblocks anddescribenames.What changed
apps/web/src/app/settings/templates/page.tsx— the save toast and the page description now cite Saved template overrides never reach outgoing email #279apps/web/src/middleware.ts— the static-asset allowlist comment describes the guarantee rather than citing an issueapps/web/src/__tests__/middleware-security.test.ts— docblock anddescribename, same treatmentapps/web/src/__tests__/templates-api.test.tsandtemplates-page.test.tsx— nine docblocks anddescribenamesNo behaviour changes; strings and comments only. No test asserts either changed string.
Checklist
apps/orpackages/