chore(infra): harden CI pipelines, security scanning, and contract tests - #821
Open
Osuochasam wants to merge 1 commit into
Open
Osuochasam wants to merge 1 commit into
Osuochasam wants to merge 1 commit into
Conversation
|
@Osuochasam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a batch of critical infrastructure, testing, and documentation improvements. It strengthens our smart contract test suite with state transition coverage, hardens CI dependency resolution, introduces automated vulnerability scanning, and adds tooling to prevent contract event documentation drift.
Key Changes
Contract State Tests: Added comprehensive unit and integration tests verifying correct behavior during paused and unpaused state transitions, including ensuring that restricted operations correctly revert while the contract is paused.
Reproducible CI Builds: Updated GitHub Actions to use strict locked dependency modes (npm ci for Node, cargo build --locked for Rust). Added a lockfile drift detection step to fail the build if dependencies attempt to modify lockfiles during CI.
Vulnerability Scanning: Integrated automated security scans (npm audit and cargo audit) into the CI pipeline. Configured the workflows to fail on High/Critical vulnerabilities while outputting Low/Medium findings as non-blocking warnings. Added docs/security.md outlining the tooling and remediation policies.
Documentation Drift Detector: Created a lightweight parser script (scripts/check-event-docs.ts) that validates documented contract events, names, and required fields against the actual contract source code. Integrated npm run check:event-docs into CI to prevent future undocumented changes.
closes #712
closes #714
closes #718
closes #719