Conversation
…iance - Add NotificationSummaryCards component and useNotificationStats hook to show delivered/pending/failed/in-flight counts with 30s polling and skeleton loading state on the Event Explorer page - Add keyword search and status filter to ChannelDetailsPage with 250ms debounce, live result count, and an EmptyState no-results view - Add license:check script to dashboard, listener, and frontend packages using license-checker with an approved SPDX allowlist (MIT, ISC, Apache-2.0, BSD-2/3-Clause, 0BSD, CC0-1.0, Unlicense, etc.) - Add contract/deny.toml for cargo-deny with matching license policy, RustSec advisory checking, and dev-dependency exclusion - Add scripts/license-policy.json documenting the approved list, disallowed licenses, tooling references, and exception process - Add license-check job to CI using EmbarkStudios/cargo-deny-action@v2 for Rust and license-checker@25 installed globally for Node packages
praizeD10
force-pushed
the
feature/notification-stats-channel-search-license-check
branch
from
September 28, 2026 16:22
e5043af to
888edcb
Compare
|
@praizeD10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
added 3 commits
September 28, 2026 18:05
…ge.json - Remove Generate/Upload fuzz coverage steps from rust CI job: the scripts/run-fuzz-coverage.sh file was deleted in upstream commit f36079b and no longer exists in the repo; the step would fail on every run - Revert listener/package.json devDependencies version bumps introduced during rebase conflict resolution of f36079b (which updated versions but never regenerated the lock file); restore ranges that match the existing package-lock.json to fix npm ci EUSAGE mismatches across all Node jobs - listener/package-lock.json root entry updated to match
- dashboard: relax engines node>=22 to >=20 (Frontend CI uses Node 20) - dashboard+listener: regenerate package-lock.json cleanly to resolve EUSAGE (@stellar/stellar-sdk entry missing in dashboard; 13 transitive entries stale in listener after commit 11d5893 partial devDep version swap) - dashboard/useDebounce.ts: align quote style with .prettierrc - listener/src/index.ts: fix two compile-time syntax bugs 1) orphan getUptimeMs property outside NotificationHealthMonitor options object (now included) + remove duplicate second healthMonitor assignment 2) redeclaration of subscriber as const after let declaration in same scope (collapsed to single assignment with ?? undefined fallback) Rust cargo fmt failure is PRE-EXISTING on main (hello-world/src/lib.rs double-nested tests/tests/ path unchanged vs this PR).
…tellar/stellar-sdk dep, botched duplicate code blocks, null-safety, SDK type mismatches
- events-server.ts/config.ts: remove duplicate import pairs (10 types + 2 route imports)
- config.ts: add missing validateSecrets/SecretValidationError import from config/validate-secrets
- listener/package.json: add @stellar/stellar-sdk ^13.3.0 dependency matching dashboard (previously undeclared, all 13 imports broke)
- event-subscriber.ts: remove duplicate processableEvents (L173-175) + duplicate request declaration (L341-362); add backfillStartLedger class field; cast response.cursor/event.receivedAt for SDK v13 type mismatches
- migration-system.ts: cast sqlite db.all return to array (fix rows.map + row implicit any); wrap logger.error in LogContext object
- compatibility-check.ts: dataFieldscontractEvent.dataFields typo (L178); expectedTopics guard before .length (null-safety L162-165); explicit (f: {name:string}) for implicit-any params
- discord-notification.ts: embed.title/footer use local coalesced vars (L382/404)
- notification-expiration.ts: (event as any).receivedAt for SDK v13 missing type
- indexing-reconciliation-engine.ts: GetEventsRequestany; response.cursor cast
- notification-stats-cache.ts: cache.hascache.get!==undefined (node-cache API mismatch)
- fixture-builder.ts: transactionIndex spread-cast (SDK EventResponse schema mismatch)
- benchmark-utils.ts: TimerTimeout cast for clearInterval compat
- request-id.ts / security-headers.ts / discord-notification sanitizeForDiscord: 4 syntax fixes (closing braces, scvString dead-code removal, http import namespace)
Listener npm run typecheck exit 0 (60+ errors 0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iance
Overview
Related Issue
Closes #499
closes #717
closes #497
Changes
Verification
How to Test
Checklist
maincargo fmt --allrun (if Rust changes)npm run lintpasses (if TypeScript changes)