Skip to content

feat: add event schema compatibility validation - #903

Open
IgweHub1 wants to merge 1 commit into
Core-Foundry:mainfrom
IgweHub1:test/event-schema-compatibility
Open

IgweHub1 wants to merge 1 commit into
Core-Foundry:mainfrom
IgweHub1:test/event-schema-compatibility

Conversation

@IgweHub1

Copy link
Copy Markdown

Closes #700

Summary

  • Adds a manifest-based event schema compatibility validator for Soroban contract events against the consumer schema.
  • Removes duplicate/conflicting contract event declarations so the source schema is canonical.
  • Adds checked-in consumer schema baseline and regression tests for valid and invalid payloads.
  • Adds CI workflow coverage for the schema compatibility gate.

Verification

listener@1.0.0 test
node ./node_modules/jest/bin/jest.js --runTestsByPath src/schema/compatibility-check.test.ts --runInBand --coverage --collectCoverageFrom=src/schema/compatibility-check.ts

------------------------|---------|----------|---------|---------|------------------------

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 70.17 57.64 73.33 73.33
compatibility-check.ts 70.17 57.64 73.33 73.33 90,172,198-202,206-248
------------------------ --------- ---------- --------- --------- ------------------------

listener@1.0.0 check:event-schema
ts-node src/schema/compatibility-check.ts --format summary

Event Schema Compatibility Check: PASS
Breaking changes: 0

Notes

  • Type-checking the entire listener package still fails because of pre-existing unrelated TypeScript syntax issues outside this issue scope.

@drips-wave

drips-wave Bot commented Sep 30, 2026

Copy link
Copy Markdown

@IgweHub1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Event Schema Compatibility Check

1 participant