test(common): add feature-isolation checks and contract tests - #217
Open
Daniele-Cangi wants to merge 1 commit into
Open
test(common): add feature-isolation checks and contract tests#217Daniele-Cangi wants to merge 1 commit into
Daniele-Cangi wants to merge 1 commit into
Conversation
Daniele-Cangi
requested review from
LorenzoTettamanti and
lorebrada
as code owners
September 2, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first hermetic slice of #198 and a focused follow-up to the shared-structure work tracked by #158.
It adds fast feature-isolation coverage for
cortexbrain-common, fixes the two monitoring cfg leaks exposed by that matrix, and adds public eBPF/userspace contract tests for event layouts, protocol conversion, and address conversion.Metadata, service-cache, and service-discovery files are intentionally untouched to avoid interfering with #216.
What changed
cargo checkmatrix covering no features, the individual event-structure features, each meaningful buffer-reader pairing, the handler pairing, the runtime feature set, and all features.SslEventaya::Podimplementation withmonitoring-structs.monitoring-structssobuffer-reader,network-structsremains isolated.aya::Pod,bytemuck::Zeroable, andCopyrequirements;The new checks require no Docker daemon, Kubernetes cluster, root access, privileged container, loaded eBPF program,
/sys/fs/bpf, network topology, or external service.Type of Change
Validation
cortexbrain-commonfeature checks pass.cargo check --locked -p cortexbrain-common --all-targets --all-featurespasses.public_contracts: 7 passed, 0 failed.The repository-wide
cargo fmt --manifest-path core/Cargo.toml --all --checkremains blocked by pre-existing missing generatedbindings.rsmodules and unrelated formatting drift; this PR does not alter those files.Refs #198
Refs #158