Repository navigation
ci: shard the 12 top-level tests/test_*.py files - #21
Conversation
git ls-files 'tests/**/test_*.py' needs a subdirectory, so the 12 files directly under tests/ were never sharded and only ran in the nightly heavy workflow, hence green PRs and a red heavy. Use the :(glob) pathspec so ** also matches zero directories (118 -> 130 files). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: adding the 12 top-level test files to CI sharding. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…nftest 'from conftest import' resolves to whichever conftest.py pytest registered first under that module name; in a shard that collects tests/trainer first it picked tests/trainer/conftest.py and failed at collection. Move the classifier into tests/systemd_probe.py, used by tests/conftest.py and the unit test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Why
ci.ymlselected test files withgit ls-files 'tests/**/test_*.py'. That pathspec needs a subdirectory, so the 13 files directly undertests/never ran in PR CI and only ran in the nightlyheavyworkflow: green PRs, redheavy(issue #19).What
One line in
.github/workflows/ci.yml:git ls-files ':(glob)tests/**/test_*.py', so**also matches zero directories. Sharded file count 118 -> 131.Files newly covered (13):
tests/test_challenge_profile_example.pytests/test_check_doc_numbers.pytests/test_check_proof.pytests/test_launch_cuda_run.pytests/test_mfu_scripts.pytests/test_mine_multi_round_v2.pytests/test_mine_smoke.pytests/test_mine_smoke_v2.pytests/test_preservation_check.pytests/test_publish_exclusions.pytests/test_smoke.pytests/test_systemd_probe_classify.py(added by Fix heavy full-suite failures other than the od-tiny fixtures (#19) #20)tests/test_vast_e2e.pyEvidence
Local run of the 13 files on main (9bec353): 133 passed, 1 skipped (gitleaks absent), 160 s total. Per-shard duration with this change: see the CI run of this PR (shard times in the checks list).
Risk / rollback
Workflow only, no
src/. Shard membership shifts (round-robin over 130 files), so each shard now carries about one extra file. Revert the merge commit.🤖 Generated with Claude Code
Summary by CodeRabbit
Update
The first CI run exposed a fragile import in #20 (
from conftest import ...resolvedtests/trainer/conftest.pyin a shard collectingtests/trainerfirst). Fixed in e6b0006 by moving the classifier intotests/systemd_probe.py; no behaviour change.