Web push - #52
Merged
Merged
Web push#52
Conversation
arifBurakDemiray
requested review from
arifBurakDemiray
and
a balanced review from Copilot
August 27, 2026 14:55
There was a problem hiding this comment.
Pull request overview
Adds web push subscription, consent, token registration, and notification-action tracking to the SDK.
Changes:
- Adds push APIs, configuration, consent, and token handling.
- Introduces a reference web push service worker.
- Adds a web push example.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
modules/CountlyClass.js |
Implements web push lifecycle and action tracking. |
modules/Constants.js |
Adds push feature and event constants. |
Countly.js |
Registers push as a consent feature. |
countly_sw.js |
Handles push notifications and clicks. |
examples/example_web_push.html |
Demonstrates web push setup and usage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.