Repository navigation
Key rules on enum parameters - #560
Merged
Merged
Conversation
lucic71
changed the title
nunoplopes
reviewed
Oct 21, 2026
| } | ||
|
|
||
| fn f5<T1: Into<i64>>(a0: u8, a1: T1) -> u8 { | ||
| a0 << Into::<i64>::into(a1) |
Contributor
There was a problem hiding this comment.
this rule is very weird. why do you need this into?? The other rules don't have that.
The result is a u8 anyway.
Contributor
Author
There was a problem hiding this comment.
f5 is a template so a1 is generic. a0 << a1 does not type check if a1 is generic. Calling into constraints the possible a1's
Contributor
There was a problem hiding this comment.
The other rules use unsigned. Generating this Into in the code is really not the right approach. A sign extend there is not helpful and can hurt performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::byte îs an enum