[pull] main from google:main#400
Merged
Merged
Conversation
InMemoryArtifactService and GcsArtifactService currently accept caller-supplied artifact://... references and later dereference the embedded scope during load_artifact() without checking that the embedded app_name, user_id, and session_id still match the caller. This patch keeps same-scope references working while blocking references that escape the caller scope. - Validate parsed artifact://... references against the caller app/user/session scope before storing them. - Validate the scope again before dereferencing an artifact reference on load. - Allow same-session references. - Allow same-user user: references across sessions. Closes #6124 Closes #6125 Co-authored-by: Jason Zhang <jasoncz@google.com> PiperOrigin-RevId: 943314213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )