[No-Jira] Update Donations rows per page

[kegrimes]

Description

HelpScout #1684480 is a suggestion to increase the default number of rows shown on the "My Donations" page. We currently show 25, which is small compared to the number donors many staff members manage.

Since the current version of MUI DataGrid does not allow pages over 100, we should keep the options the same (25, 50, and 100) but default to 100 rows.

Testing

• Impersonate: courtney.campbell@cru.org
• Go to /reports/donations
• Go to "August 2024"
• Check that the rows per page default is 100

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /quality:agent-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Preview branch generated at https://change-donations-table-default.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 6da175b

No significant changes found

[kegrimes]

🤖 Multi-Agent Code Review — CLEAN ✅

Verdict: CLEAN — no findings at severity ≥ 5. Safe to merge.

Risk: 1/10 (LOW) · 1 file · +1/−1 · Required reviewer: ANY
Agents: Architecture, Testing, Standards, UX — all High confidence · Debate skipped (no findings ≥ severity 7) · Coverage: the changed line was directly analyzed by all 4 agents.

Change

DonationTable initial pageSize 25 → 100 (one line, DonationTable.tsx:151).

What was verified

• Architecture — Interacts well with the existing design: useFetchAllPages already eager-loads every page and pageSize flows into the query variables, so 100 means ~¼ the round-trips (fewer, not more). No N+1 / over-fetch. Neutral tech debt.
• UX — @mui/x-data-grid@8.9.2 (Community) caps page size at 100, so 100 is exactly at the cap — safe, no max-size error. pageSizeOptions is unset → MUI default [25, 50, 100], and 100 is a member, so no console warning. disableVirtualization + 100 rows assessed concretely (~800 lightweight cells) — not a jank concern. Loading + progress states already wired.
• Testing — No existing test breaks: toHaveGraphqlOperation assertions are partial (don't pin pageSize), mocks have 2 nodes so row-slicing is identical, and the rows-per-page test selects 50 (still valid). No new test warranted.
• Standards — Zero violations. Bare pageSize literals are the dominant convention (4 of 6 tables, incl. the sibling UpdateDonationsModal); no shared page-size constant exists. No convention drift vs. CLAUDE.md / rules.

Informational (severity 2.5 — no action needed)

• DonationTable.tsx:151 — 100 is a magic number, but bare pageSize literals are the established pattern across tables and there's no shared constant to reuse. Extracting one is optional, not recommended for a 1-line change.

Agent	Critical	High	Important	Suggestions	Confidence
Architecture	0	0	0	0	High
Testing	0	0	0	1	High
Standards	0	0	0	0	High
UX	0	0	0	0	High
Total	0	0	0	1	High

_{Generated by /quality:agent-review (standard mode).}

[github-actions]

AI Review Auto-Approval

Risk Level: LOW (1/10)
Verdict: CLEAN (no issues found)

This PR was auto-approved because:

• The multi-agent AI review determined it is low risk
• No blocking issues were found

If you believe this PR needs human review, dismiss this approval and request a review manually.