Feature: Update Legal-Page Banner Design - #329
Open
aditya123123123123 wants to merge 2 commits into
Open
Conversation
- re-ran 'npx prettier --write .' command for codebase consistency
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jschhie
requested changes
Aug 31, 2026
Collaborator
There was a problem hiding this comment.
PR #329 Review
Thanks for recreating your PRs :)
Everything looks good, but just noticed a responsive bug on tablet (see below).
Manual Tests
- Tested on local dev & deployed on personal Vercel
- Checked responsive design:
- Mobile & tablet (landscape/portrait orientations)
- Browser resizing (
1680pxdown to360px) on desktop
Requested Changes
fix:Pixelated/Blurry Icons on Tablet
- When testing on my personal Vercel deployment, Carl and the speech bubble icon look a bit pixelated and blurry on tablet (especially in landscape mode)
- Could you please check the aspect ratio/CSS sizing on tablet viewports?
| Portrait | Landscape |
|---|---|
chore:Prettier Formatting
- I just pushed an extra
chorecommit to apply Prettier for codebase consistency (no other changes) - Please run
git pulllocally before pushing additional changes! - Friendly reminder for future PRs: Be sure to run
npx prettier --write .per contributing guidelines to prevent unexpected git diffs :)
docs:Inline Docs (Suggestion/Nit)
- Your variable naming is clear, but adding a brief comment above computed properties or helper functions would be helpful for future maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Feature
Approach
lg:gridtransition at exactly 1024px without changing the shared device-detection composable.Dependencies / Configuration
Scope
preprod.src/components/AccountPages/Banner.vuesrc/pages/Footer/PrivacyPolicy.vuesrc/pages/Footer/TermsOfUse.vueAccessibility
aria-hidden="true"and empty image alt text.Screenshots / Logs
Manual Tests
npm cinpm run buildgit diff --checkpreprodpreproddid not move before publishing (0 0divergence)Review / Merge
featureCloses #326