Skip to content

add langchain standard integration test#10

Merged
euphoria0-0 merged 19 commits into
mainfrom
feat/add-lc-tests
Jan 2, 2026
Merged

add langchain standard integration test#10
euphoria0-0 merged 19 commits into
mainfrom
feat/add-lc-tests

Conversation

@euphoria0-0
Copy link
Copy Markdown
Contributor

@euphoria0-0 euphoria0-0 commented Dec 24, 2025

LangChain standard integration test 를 추가합니다.
standard test의 output에 맞춰서 vector store output도 수정하였습니다.

ENVECTOR_ADDRESS="localhost:50050" ENVECTOR_KEY_PATH="./keys" ENVECTOR_KEY_ID="test_key" ENVECTOR_INDEX_NAME="test_index" python -m pytest -q -rs

@euphoria0-0 euphoria0-0 marked this pull request as ready for review December 29, 2025 03:02
@euphoria0-0 euphoria0-0 requested a review from Copilot December 29, 2025 03:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds LangChain standard integration tests to verify the Envector vector store implementation conforms to LangChain's test suite. The changes introduce a new integration test file that leverages LangChain's VectorStoreIntegrationTests base class and adds a unit test to verify document ID handling behavior.

Key changes:

  • Adds LangChain standard integration test class that runs against a live Envector instance
  • Adds unit test for document ID handling to ensure IDs are ignored and item IDs are returned
  • Updates dependencies to include langchain-core and langchain-tests packages

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_vectorstore.py Adds unit test verifying that add_documents ignores user-provided IDs and returns item IDs
tests/requirements.txt Updates dependencies to use pyenvector package and adds langchain-core and langchain-tests
tests/integration_tests/test_vectorstore.py New integration test file implementing LangChain's standard vector store test suite
README.md Clarifies environment variables needed for integration tests
.github/workflows/pr.yml Adds langchain-tests installation to CI workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_vectorstore.py Outdated
Comment thread tests/integration_tests/test_vectorstore.py Outdated
@euphoria0-0 euphoria0-0 requested a review from Copilot December 29, 2025 05:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libs/envector/langchain_envector/vectorstore.py Outdated
Comment thread libs/envector/langchain_envector/vectorstore.py Outdated
@euphoria0-0 euphoria0-0 requested a review from Copilot December 30, 2025 06:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/requirements.txt
Comment thread libs/envector/langchain_envector/vectorstore.py
@SongHyeopPark
Copy link
Copy Markdown
Collaborator

test에 필요한 dependency 설치 방법을 추가해주실수있으신가요?

@euphoria0-0
Copy link
Copy Markdown
Contributor Author

euphoria0-0 commented Jan 2, 2026

test에 필요한 dependency 설치 방법을 추가해주실수있으신가요?

@SongHyeopPark 추가했습니다! c43351b

@euphoria0-0 euphoria0-0 merged commit 95653b0 into main Jan 2, 2026
1 check passed
@euphoria0-0 euphoria0-0 deleted the feat/add-lc-tests branch January 2, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants