ES2-975) add_documents#5
Merged
Merged
Conversation
…ine test runner, and doc updates (README, VECTORSTORE.md)
inkme9
force-pushed
the
feature/ES2-975-add-documents
branch
2 times, most recently
from
e51baae to
1ac729b
Compare
inkme9
force-pushed
the
feature/ES2-975-add-documents
branch
2 times, most recently
from
dffc969 to
dc80d06
Compare
inkme9
force-pushed
the
feature/ES2-975-add-documents
branch
from
dc80d06 to
78e6815
Compare
euphoria0-0
reviewed
Oct 13, 2025
euphoria0-0
approved these changes
Oct 13, 2025
euphoria0-0
reviewed
Oct 13, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the add_documents method to the Envector vector store, along with comprehensive testing, formatting improvements, and CI setup.
- Implements
add_documentsmethod that accepts LangChain Document objects and delegates toadd_texts - Adds comprehensive test coverage for the new functionality including edge cases
- Sets up pre-commit hooks and GitHub Actions workflow for automated linting and testing
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
libs/envector/langchain_envector/vectorstore.py |
Implements the add_documents method with proper error handling |
tests/test_vectorstore.py |
Adds extensive test coverage for add_documents and related functionality |
.pre-commit-config.yaml |
Configures automated linting with ruff and black formatting |
.github/workflows/pr.yml |
Sets up CI workflow for pull request validation |
| Multiple files | Code formatting improvements and import cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.