PropertyFieldView - #333
Open
cmhamel wants to merge 1 commit into
Open
Conversation
…ays. The only things StaticArrays offers us isbits-ness. But this PropertyFieldView type is also isbits. If we only need properties for e.g. elastoplastic models, then StaticArrays is just fine since we'll usually be under ~10 parameters. However, for viscoelastic models, we could easily get into the dozens or even over a hundred individual parameters where StaticArrays become less competetive and can lead to subtsantial compile times. This PR slightly reverts some things but not by much. Tested against the whole Carina.jl test suite.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 70.91% 70.92%
=======================================
Files 54 54
Lines 6289 6291 +2
=======================================
+ Hits 4460 4462 +2
Misses 1829 1829 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding PropertyFieldView type so we don't need to resort to StaticArrays. The only things StaticArrays offers us isbits-ness. But this PropertyFieldView type is also isbits. If we only need properties for e.g. elastoplastic models, then StaticArrays is just fine since we'll usually be under ~10 parameters. However, for viscoelastic models, we could easily get into the dozens or even over a hundred individual parameters where StaticArrays become less competetive and can lead to subtsantial compile times. This PR slightly reverts some things but not by much. Tested against the whole Carina.jl test suite.