-
Notifications
You must be signed in to change notification settings - Fork 4
feat(config): a suggestions option that stops backend generation #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Antisophy
wants to merge
1
commit into
CyberShadow:master
Choose a base branch
from
Antisophy:feat/suggestions-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,10 @@ import cydo.workflow.history.abbrev : buildAbbreviatedHistoryFromStrings; | |
| struct DerivedTextJobsHost | ||
| { | ||
| TaskData* delegate(int tid) getTask; | ||
| /// Whether suggestion generation is enabled at all (config `suggestions`); | ||
| /// null means enabled. Gating here stops the backend one-shots themselves, | ||
| /// not just the display. | ||
| bool delegate() suggestionsEnabled; | ||
| int[] delegate() snapshotTaskIds; | ||
| Agent delegate(int tid) agentForTask; | ||
| bool delegate(int tid) hasSubscribers; | ||
|
|
@@ -144,6 +148,8 @@ public: | |
|
|
||
| void generateSuggestions(int tid) | ||
| { | ||
| if (host_.suggestionsEnabled !is null && !host_.suggestionsEnabled()) | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessarily defensive - will never be |
||
| return; | ||
| auto td = host_.getTask(tid); | ||
| if (td is null) | ||
| return; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { | ||
| test, | ||
| expect, | ||
| enterSession, | ||
| sendMessage, | ||
| responseTimeout, | ||
| assistantText, | ||
| } from "./fixtures"; | ||
| import { writeTestConfig } from "./test-config"; | ||
|
|
||
| // `suggestions: false` stops the backend from generating next-message | ||
| // suggestions at all: the one-shot is never issued, so the suggestion bar | ||
| // never populates. | ||
| test("suggestions: false stops backend generation", async ({ | ||
| page, | ||
| agentType, | ||
| }) => { | ||
| writeTestConfig( | ||
| "/tmp/playwright-home/.config/cydo/config.yaml", | ||
| `default_agent: ${agentType} | ||
| log_level: trace | ||
| suggestions: false | ||
| workspaces: | ||
| local: | ||
| root: /tmp/cydo-test-workspace | ||
| `, | ||
| ); | ||
| // Give the backend's inotify watcher time to reload the config. | ||
| await page.waitForTimeout(500); | ||
|
|
||
| await enterSession(page); | ||
| await sendMessage(page, 'Please reply with "one"'); | ||
| await expect(assistantText(page, "one")).toBeVisible({ | ||
| timeout: responseTimeout(agentType), | ||
| }); | ||
|
|
||
| // A second full turn bounds the wait without a wall-clock sleep: had the | ||
| // first turn generated suggestions, they would have rendered long before | ||
| // the second turn completes, since the generation one-shot answers from | ||
| // the same mock as the turns themselves. | ||
| await sendMessage(page, 'Please reply with "two"'); | ||
| await expect(assistantText(page, "two")).toBeVisible({ | ||
| timeout: responseTimeout(agentType), | ||
| }); | ||
|
|
||
| await expect(page.locator(".btn-suggestion")).toHaveCount(0); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just do
@Optional bool suggestions = true;?