Fix shell search suggestion pick after dismissing OSK with B#7
Closed
CyberoniOntoni wants to merge 1 commit into
Closed
Fix shell search suggestion pick after dismissing OSK with B#7CyberoniOntoni wants to merge 1 commit into
CyberoniOntoni wants to merge 1 commit into
Conversation
Owner
Author
|
Superseded by upstream PR dfederm#101. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
When searching from the shell
AutoSuggestBoxon Xbox, pressing B to dismiss the on-screen keyboard spuriously firedQuerySubmitted/SuggestionChosenwith the first suggestion, immediately navigating to that title instead of letting the user browse the list with the d-pad.This change suppresses those dismiss events, routes deliberate picks only through
SuggestionChosen(A on a highlighted row), keeps the search box focusable while suggestions are open, and setsUpdateTextOnSelect="False"so partial query text is preserved.Stacked on dfederm#98 — merge after dfederm#98 (shell search + Xbox focus) lands.
Fixes #
Type of change
Checklist
msbuild JellyBox.sln -t:Build -p:Configuration=Debug -p:Platform=x64succeeds with 0 warnings and 0 errors (verified Release x64 locally via MSBuild).Manual test notes
Windows desktop (Release x64 build, 0 warnings/errors). Xbox verification still needed — intended flow:
Screenshots / recording
Not yet captured — Xbox screen recording to be added after device verification.
Out of scope / follow-ups