Fix shell search suggestion pick after dismissing OSK with B#8
Closed
CyberoniOntoni wants to merge 1 commit into
Closed
Fix shell search suggestion pick after dismissing OSK with B#8CyberoniOntoni wants to merge 1 commit into
CyberoniOntoni wants to merge 1 commit into
Conversation
CyberoniOntoni
force-pushed
the
fix/search-suggestion-gamepad
branch
from
686005f to
387bdeb
Compare
Owner
Author
|
Tracked upstream as dfederm#101. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Pressing B to dismiss the on-screen keyboard while shell search suggestions are open spuriously navigated to the first result. This suppresses those dismiss events so the user can browse suggestions with the d-pad and confirm with A.
Merge after dfederm#98 (stacked on
feature/xbox-shell-focus).Manual test notes
Release x64 build — 0 warnings/errors. Intended flow: type partial title → suggestions appear → B closes OSK without navigating → d-pad to a row → A opens item details. Xbox recording pending.
Out of scope
Shell search bar and suggestion API are in dfederm#98.