Clean check-in of AI/ML. Supersedes #948. - #990
Conversation
…ore work to do. Signed-off-by: Steve Springett <steve@springett.us>
|
There are multiple things that are currently broken with #948 that this PR will attempt to resolve. This includes references to objects that no longer exist in 2.0, improper use of objects in 2.0, and lack of integration with the component model. This PR will also introduce the required test fixtures (valid / invalid) necessary for the RFC period. |
Signed-off-by: Steve Springett <steve@springett.us>
|
Thanks for moving the AI/ML work into a clean in-repository branch. The tensor-level affine quantization gap I raised on #948 still seems to apply here. The reproducible TFLite evidence, the ONNX correspondence (per-tensor, per-axis, and blocked granularity), and a proposed framework-neutral shape are all in that comment: I understand that the draft is still being stabilized, so no response is needed at this stage. Once the structure and fixtures settle, I would be glad to help with the aligned JSON, XML, and protobuf definitions and the corresponding valid and invalid tests. |
|
@stevespringett @mrutkows One small integration check following my review on CycloneDX/cyclonedx-property-taxonomy#175. After #990 was opened, commit Was the later Either location would preserve named-parameter binding. I am asking only so that the quantization worked examples in CycloneDX/cyclonedx-property-taxonomy#175 use the intended canonical location. |
Signed-off-by: Steve Springett <steve@springett.us>
|
@mrutkows can you please take a look and see if this PR matches your expectation of the way the new AI model should look. Also look at the test cases. NOTE: This PR makes assumptions that other PRs (currently in the public RFC period and not yet approved by TC54) have received positive votes and have been merged. |
|
@stevespringett Perhaps we should meet to review to assure this gets the dedicated time needed for closure. Here are the summary of changes that need review: 1 · Core Concept Change Matt: modelCard is an industry term and IMO we would regret not adopting the term as a grouping (despite alternate "views" being possible via CDX) and taking a stand on the elements that make up a modelCard. 2 · Architecture Definitions Refactored The nested structural { primary, secondary, topologyType } object inside modelArchitecture is replaced by three standalone top-level definitions: architectureFamily, architectureFeature, and architectureTopology. Each uses a oneOf (predefined enum | custom extension object), which is cleaner than the old anyOf with regex patterns. Matt: Nesting of the 3 elements of a model arch. seemed cleaner... 3 · Risk/Ethics Definitions Removed Matt: Assume these are moved elsewhere? 4 · modelParameter Massively Enriched Matt: I believe that aligned with the additions proposed in the other PR... have to verify 1-by-1 5 · Measure Types Moved to Common Schema Matt: assume these was moved elsewhere as you conveyed the last few months... 6 · Bug Fixes TYVM Key Discussion Points:
Matt: Discuss if this really disappeared?
Matt: Discuss? enum. may be too untenable, but CDX property perhaps?
Matt: Was really hoping to go in this direction to assure we limit property values to those property names that match (to encourage correctness of information); otherwise any URN value works and prevents at some validation of correctness. Understand that this is a new precedent...
Matt: I have no idea how to contain this other than a full review once we have most of 2.0 schema finalized... |
|
Another "Advisor" reiterated the points of discussion:
|
mrutkows
left a comment
There was a problem hiding this comment.
Would like to discuss the comments I added in the PR's conversation...
| } | ||
| }, | ||
| "learningType": { | ||
| "title": "Learning Type", |
There was a problem hiding this comment.
Why is this repeated when already listed above? Why is this repeated when already listed above? Maybe take away the "Learning Type" above?
| ] | ||
| }, | ||
| "modelTask": { | ||
| "title": "Model Task", |
There was a problem hiding this comment.
Why is this repeated when already listed above? Maybe take away the "task" above?
This PR supersedes #948, which introduced a number of unnecessary changed files and originated outside of the specification repo.