Skip to content

Allow clearing Dark Tanks in the crafting grid - #1242

Merged
rubensworks merged 2 commits into
master-1.21-ltsfrom
copilot/suggestion-void-tank-recipe
Aug 3, 2026
Merged

Allow clearing Dark Tanks in the crafting grid#1242
rubensworks merged 2 commits into
master-1.21-ltsfrom
copilot/suggestion-void-tank-recipe

Conversation

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Dark Tanks could retain unwanted fluid with no direct way to discard it. This adds a one-item crafting recipe that returns the same tank with its fluid content removed.

  • Recipe support

    • Adds a special fluid-container clearing recipe and serializer.
    • Preserves tank metadata such as capacity while removing fluid content.
    • Registers the recipe for evilcraft:dark_tank.
  • Coverage

    • Adds a game test verifying that a filled Dark Tank crafts into an empty tank.
{
  "type": "evilcraft:crafting_special_fluidcontainer_clear",
  "item": {
    "item": "evilcraft:dark_tank"
  }
}

@coveralls

coveralls commented Aug 3, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 30838396084

Coverage increased (+0.1%) to 29.393%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 15 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

15 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
org/cyclops/evilcraft/EvilCraft.java 13 0.0%
org/cyclops/evilcraft/block/BlockSpiritPortal.java 2 67.57%

Coverage Stats

Coverage Status
Relevant Lines: 15171
Covered Lines: 5187
Line Coverage: 34.19%
Relevant Branches: 5640
Covered Branches: 930
Branch Coverage: 16.49%
Branches in Coverage %: Yes
Coverage Strength: 1.6 hits per line

💛 - Coveralls

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot AI changed the title [WIP] Add ability to void tank by placing it on the crafting grid Allow clearing Dark Tanks in the crafting grid Aug 3, 2026
Copilot AI requested a review from rubensworks August 3, 2026 17:54
@rubensworks
rubensworks marked this pull request as ready for review August 3, 2026 17:56
@rubensworks
rubensworks merged commit 5729394 into master-1.21-lts Aug 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Suggestion] Allow the ability to void a tank by placing on the crafting grid alone

3 participants