Add connector#286
Conversation
jbndbc
left a comment
jbndbc
left a comment
There was a problem hiding this comment.
Kan vi ikke også omdøbe modulet fra commons/utils/rawrepo-update-dm3-service-connector til commons/utils/rawrepo-update-v3-service-connector
| MARCCONV, | ||
| OPENUPDATE, | ||
| PERIODIC_JOBS, | ||
| RAWREPO_UPDATE_DM3, |
There was a problem hiding this comment.
Kan vi ikke helt undgå at bruge dm3 i navne, men v3 i stedet. Det er meget mindre indforstået.
| * REST connector for the rawrepo-v3 update-service. | ||
| * Instances of this class are thread safe as long as the underlying HTTP client is thread safe. | ||
| */ | ||
| public class RawrepoUpdateDm3ServiceConnector { |
There was a problem hiding this comment.
RawrepoUpdateV3ServiceConnector
| private static final RetryPolicy<Response> RETRY_POLICY = new RetryPolicy<Response>() | ||
| .handle(ProcessingException.class) | ||
| .handleResultIf(response -> | ||
| response.getStatus() == 404 |
There was a problem hiding this comment.
Er vi sikre på, at vi ikke hellere vil retry'e 500 i stedet for 404?
| private final String baseUrl; | ||
| private final boolean validateOnly; | ||
|
|
||
| public RawrepoUpdateDm3ServiceConnector(Client httpClient, String baseUrl) { |
There was a problem hiding this comment.
UserAgent bør gives med som argument.
Under alle omstændigheder tænker jeg ikke vi bør defaulte til RawrepoUpdateDm3ServiceConnector.class.getName(), med mindre der er tale om test.
|
|
||
| ~~Record-format konvertering~~ — ikke relevant. | ||
|
|
||
| Chunk-items indeholder ét JSON-objekt direkte (ikke ADDI): |
There was a problem hiding this comment.
Jeg er ikke sikker på, at vi nøjes med denne struktur, men lad os lige stikke hovederne sammen.
| @@ -0,0 +1,108 @@ | |||
| # Plan: rawrepo-update sink (update-service v3) | |||
There was a problem hiding this comment.
Er det et bevidst valg at planen er committed?
2 participants
No description provided.