Let search work in any slot: keep the form aligned and continue tab order from its button - #545
Merged
Merged
Conversation
…rder from its button While search is open, every other item in the top row (buttons, button groups and controls) is taken out of flow as well as hidden, so nothing offsets the form within its column when it isn't in top-left. They stay focusable. A slot renders its controls before its buttons, so native Tab order left the open form for whatever followed it in the DOM, not the search button. handleTabOut now continues from the button: Tab past the form's last element goes to whatever follows the button, and Shift+Tab past its first returns to the button. The index and draw demos put search in the top-right on tablet/desktop.
|
markfee
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While search is open, every other item in the top row (buttons, button groups and controls) is taken out of flow as well as hidden, so nothing offsets the form within its column when it isn't in top-left. They stay focusable.
A slot renders its controls before its buttons, so native Tab order left the open form for whatever followed it in the DOM, not the search button. handleTabOut now continues from the button: Tab past the form's last element goes to whatever follows the button, and Shift+Tab past its first returns to the button.
The index and draw demos put search in the top-right on tablet/desktop.