Move fullscreen and map controls to top-right by default, fix hidden top column measurement - #547
Merged
Merged
Conversation
…top column measurement Fullscreen and map controls now default to the top-right slot, with zoom staying in right-top. This changes the default layout for all consumers. A top-row column whose children are all hidden (hiddenWhen buttons, or items hidden by a plugin's exclusive-control CSS) isn't :empty, so it kept its trailing padding and pushed the side column below it down by a gap. calculateLayout now measures such a column as empty.
|
markfee
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fullscreen and map controls now default to the top-right slot, with zoom staying in right-top. This changes the default layout for all consumers.
A top-row column whose children are all hidden (hiddenWhen buttons, or items hidden by a plugin's exclusive-control CSS) isn't :empty, so it kept its trailing padding and pushed the side column below it down by a gap. calculateLayout now measures such a column as empty.