Skip to content

fix(lib): remove unused ts-expect-error for clean Next.js build #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JOY (JOY) merged 1 commit into from
Sep 3, 2026
Merged

fix(lib): remove unused ts-expect-error for clean Next.js build #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/lib/hooks/useRouterQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ function fromEntriesWithDuplicateKeys(entries: IterableIterator<[string, string]
return result;
}

// Consider setting atleast ES2015 as target
// @ts-expect-error
for (const [key, value] of entries) {
if (result.hasOwnProperty(key)) {

@gemini-code-assist gemini-code-assist Bot Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

Using result.hasOwnProperty(key) directly on an object can lead to runtime errors or unexpected behavior if the query parameters contain keys that match prototype properties (e.g., hasOwnProperty, toString). For example, if a query parameter is hasOwnProperty=123, result.hasOwnProperty will be overwritten, and subsequent calls to result.hasOwnProperty(key) will throw a TypeError: result.hasOwnProperty is not a function, crashing the application.

To prevent this, use Object.hasOwn(result, key) (or Object.prototype.hasOwnProperty.call(result, key)).

Additionally, please note that this function is duplicated in packages/lib/fromEntriesWithDuplicateKeys.ts. You should apply the same fix there, or ideally, refactor the code to import fromEntriesWithDuplicateKeys from a single shared location to avoid duplication.

Suggested change
if (result.hasOwnProperty(key)) {
if (Object.hasOwn(result, key)) {

let currentValue = result[key];
Expand Down
Loading