Skip to content

port: hash inner packet fields by default#630

Open
maxime-leroy wants to merge 1 commit into
DPDK:mainfrom
maxime-leroy:rss_inner
Open

port: hash inner packet fields by default#630
maxime-leroy wants to merge 1 commit into
DPDK:mainfrom
maxime-leroy:rss_inner

Conversation

@maxime-leroy

@maxime-leroy maxime-leroy commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Request innermost RSS level in the default port configuration.

This makes the RSS hash use inner packet fields when the PMD supports RSS levels, which improves distribution for tunnelled traffic with fixed outer headers.

Updated default_port_config.rx_adv_conf.rss_conf.rss_hf in modules/infra/control/port.c to format the RSS hash flag initializer by removing the trailing comma after RTE_ETH_RSS_TCP, while keeping the same RSS hash flags set: RTE_ETH_RSS_VLAN | RTE_ETH_RSS_IP | RTE_ETH_RSS_UDP | RTE_ETH_RSS_TCP | RTE_ETH_RSS_LEVEL_INNERMOST.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0ad95ccf-27cf-4076-8fed-514e5367285e

📥 Commits

Reviewing files that changed from the base of the PR and between 4548463 and 8a982a9.

📒 Files selected for processing (1)
  • modules/infra/control/port.c
✅ Files skipped from review due to trivial changes (1)
  • modules/infra/control/port.c

📝 Walkthrough

Walkthrough

In modules/infra/control/port.c, the rss_hf field of default_port_config.rx_adv_conf.rss_conf was reformatted: the RTE_ETH_RSS_TCP and RTE_ETH_RSS_LEVEL_INNERMOST bitmask entries were reflowed across two lines with adjusted punctuation. No functional or behavioral change is introduced.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Request innermost RSS level in the default port configuration.

This makes the RSS hash use inner packet fields when the PMD supports RSS
levels, which improves distribution for tunnelled traffic with fixed outer
headers.

Signed-off-by: Maxime Leroy <maxime@leroys.fr>
Reviewed-by: Robin Jarry <rjarry@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants