Repository navigation
refactor(ellipsisText): add dynamic prop for ellipsis modes (DTStack#666) - #667
Merged
Merged
Conversation
LuckyFBB
reviewed
Oct 9, 2026
Collaborator
|
有 tooltip 相关的内容,要不把这块的内容直接改为 tooltip ?然后用 toTooltipProps 转一下? |
Collaborator
Author
历史逻辑中使用 // 改造前:title 为提示内容,其余 props 隐式透传给 Tooltip
<EllipsisText value={title} title={tip} mouseEnterDelay={0.5} placement="topLeft" />
// 改造后:title 属性已移除,统一用 tooltip 配置(字符串/ReactNode 或完整 TooltipProps 对象)
<EllipsisText value={title} tooltip={{ title: tip, mouseEnterDelay: 0.5, placement: 'topLeft' }} /> |
LuckyFBB
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更类型
请选择以下选项以描述 PR 的类型:
相关问题
#666
详细描述
EllipsisText 组件的动态计算功能是在 rc@4.x 新增的功能,在实现上,动态计算是融入了
maxWidth的计算中的,融入了 EllipsisText 组件中的宽度计算逻辑。即不论需不需要动态计算功能,都会走动态计算逻辑。这一点引出了很多的问题。在调研了 Antd 的 Typography.Text 组件后,Antd 的 Typography.Text 组件除了动态计算剩余宽度的功能外,其余功能都已实现。故此,对 EllipsisText 做以下改造:
变更内容
title属性替换为tooltip属性(LabelTooltipType,即TooltipProps['title'] | TooltipProps),经toTooltipProps统一转换;移除原先其余 props 透传给 Tooltip 的隐式行为([propName: string]: any),静态 / 动态两条路径共用同一份 tooltip 配置。迁移
对应 Previewer
https://jin-sir.github.io/dt-react-component/components/ellipsis-text