docs: record SmolLM2 Transformers compatibility - #12
Conversation
DaBestCode
left a comment
There was a problem hiding this comment.
Maintainer review is positive. I verified the pinned SmolLM2 revision, checked the cache arithmetic (30 layers × 3 KV heads × 9 rounds = 810 head evictions), and ran the complete local suite: Ruff, formatting, mypy, 25 tests, and package build all pass.
The compatibility table correctly separates verified evidence from expected support, and the raw result makes no comparative performance or quality claim. No code changes are requested.
Because this PR is still a draft, please mark it ready for review when you consider it complete. I am approving the blocked Actions workflow now; once the hosted Python 3.10/3.13 matrix passes, this should be ready for formal approval.
DaBestCode
left a comment
There was a problem hiding this comment.
Approved after local and hosted verification. The SmolLM2 revision is pinned, the raw counters are internally consistent, the compatibility language is appropriately scoped, and Ruff, formatting, mypy, tests, build, and GitGuardian all pass. Please mark the PR ready for review when you are ready to merge.
|
Please rebase and I will approve the PR. Thank you! |
c3899ea to
2e63065
Compare
|
Rebased onto the latest main and resolved the documentation conflict while preserving both the upstream schema-compatibility section and the SmolLM2 compatibility entry. The rebased head is 2e63065. Local verification passes: Ruff, formatting, mypy, pytest (43 passed), and uv build --offline. The branch is clean and ready for approval. |
|
GitHub created a new CI run for the rebased commit, but it is currently waiting for maintainer approval again because the branch is from a fork. The local verification is complete and the existing approval remains recorded. Please approve/run the new CI workflow when convenient. |
Summary
Closes #4
HuggingFaceTB/SmolLM2-135MVerification
ruff check .ruff format --check .mypy srcpytest -q(25 passed)uv build --offlineSmoke evidence
93efa2f097d58c2a74874c7e644dbc9b0cee75a26481289per layerresults/smollm2-135m-smoke.jsonThe smoke result is compatibility and eviction-behavior evidence only. It is not a throughput comparison or model-quality evaluation.